From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: krzk@kernel.org, 20240409185416.2224609-1-Frank.Li@nxp.com,
conor+dt@kernel.org, devicetree@vger.kernel.org,
dmaengine@vger.kernel.org, imx@lists.linux.dev,
krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
pankaj.gupta@nxp.com, peng.fan@nxp.com, shengjiu.wang@nxp.com,
shenwei.wang@nxp.com, vkoul@kernel.org, xu.yang_2@nxp.com
Subject: Re: [PATCH v4 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property
Date: Tue, 16 Apr 2024 08:19:40 -0500 [thread overview]
Message-ID: <20240416131940.GA2138646-robh@kernel.org> (raw)
In-Reply-To: <20240412154208.881836-2-Frank.Li@nxp.com>
On Fri, Apr 12, 2024 at 11:42:08AM -0400, Frank Li wrote:
> Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need
> it. EDMA supports each power-domain for each dma channel. So minItems and
> maxItems align 'dma-channels'.
>
> Change fsl,imx93-edma3 example to fsl,imx8qm-edma to reflect this variants.
>
> Fixed below DTB_CHECK warning:
> dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>
> Notes:
> Change from v3 to v4
> - Remove 'contains' change should be belong to first patch when rebase.
>
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,edma.yaml
> LINT Documentation/devicetree/bindings
> DTEX Documentation/devicetree/bindings/dma/fsl,edma.example.dts
> CHKDT Documentation/devicetree/bindings/processed-schema.json
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
> DTC_CHK Documentation/devicetree/bindings/dma/fsl,edma.example.dtb
>
> After this patch no warning for imx8dxl-evk.dtb.
>
> touch arch/arm64/boot/dts/freescale/imx8dxl.dtsi
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 CHECK_DTBS=y freescale/imx8dxl-evk.dtb
> DTC_CHK arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb
>
> Change from v2 to v3
> - set 'power-domains' false for other compatitble string
> - change imx93 example to 8qm example to affect this change according to
> Krzysztof Kozlowski's suggestion, choose least channel number edma
> instance to reduce code copy. max channel number is 64.
>
> - Rebase to latest dmaengine/next, fixes conflicts.
>
> Change from v1 to v2
> - using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
> - add power-domains to 'required' when compatible string is fsl,imx8qm-adma
> or fsl,imx8qm-edma
>
> .../devicetree/bindings/dma/fsl,edma.yaml | 77 ++++++++++---------
> 1 file changed, 39 insertions(+), 38 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index fb5fbe4b9f9d4..012522612dc96 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> @@ -71,6 +71,10 @@ properties:
> minItems: 1
> maxItems: 33
>
> + power-domains:
> + minItems: 1
> + maxItems: 64
Please state here that number of power-domains are equal to number of
channels and in ascending order.
Rob
prev parent reply other threads:[~2024-04-16 13:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 15:42 [PATCH v4 1/2] dt-bindings: dma: fsl-edma: remove 'clocks' from required Frank Li
2024-04-12 15:42 ` [PATCH v4 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property Frank Li
2024-04-16 13:19 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416131940.GA2138646-robh@kernel.org \
--to=robh@kernel.org \
--cc=20240409185416.2224609-1-Frank.Li@nxp.com \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.gupta@nxp.com \
--cc=peng.fan@nxp.com \
--cc=shengjiu.wang@nxp.com \
--cc=shenwei.wang@nxp.com \
--cc=vkoul@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).