From: Vinod Koul <vkoul@kernel.org>
To: Dave Jiang <dave.jiang@intel.com>, Fenghua Yu <fenghua.yu@intel.com>
Cc: dmaengine@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Lijun Pan <lijun.pan@intel.com>
Subject: Re: [PATCH] dmaengine: idxd: Avoid unnecessary destruction of file_ida
Date: Sat, 04 May 2024 18:17:15 +0530 [thread overview]
Message-ID: <171482683528.61200.11644725480487646401.b4-ty@kernel.org> (raw)
In-Reply-To: <20240130013954.2024231-1-fenghua.yu@intel.com>
On Mon, 29 Jan 2024 17:39:54 -0800, Fenghua Yu wrote:
> file_ida is allocated during cdev open and is freed accordingly
> during cdev release. This sequence is guaranteed by driver file
> operations. Therefore, there is no need to destroy an already empty
> file_ida when the WQ cdev is removed.
>
> Worse, ida_free() in cdev release may happen after destruction of
> file_ida per WQ cdev. This can lead to accessing an id in file_ida
> after it has been destroyed, resulting in a kernel panic.
>
> [...]
Applied, thanks!
[1/1] dmaengine: idxd: Avoid unnecessary destruction of file_ida
commit: 76e43fa6a456787bad31b8d0daeabda27351a480
Best regards,
--
~Vinod
prev parent reply other threads:[~2024-05-04 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 1:39 [PATCH] dmaengine: idxd: Avoid unnecessary destruction of file_ida Fenghua Yu
2024-01-30 15:34 ` Dave Jiang
2024-04-29 20:56 ` Fenghua Yu
2024-05-04 12:47 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171482683528.61200.11644725480487646401.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fenghua.yu@intel.com \
--cc=lijun.pan@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).