From: Rob Herring <robh@kernel.org>
To: bin.yao@ingenic.com
Cc: krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
dmaengine@vger.kernel.org, conor+dt@kernel.org,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
vkoul@kernel.org, 1587636487@qq.com
Subject: Re: [PATCH 2/2] dt-bindings: dma: Convert ingenic-pdma doc to YAML
Date: Thu, 21 Mar 2024 04:23:46 -0500 [thread overview]
Message-ID: <171101302544.1214225.13077812930159228555.robh@kernel.org> (raw)
In-Reply-To: <20240321080228.24147-2-bin.yao@ingenic.com>
On Thu, 21 Mar 2024 16:02:28 +0800, bin.yao@ingenic.com wrote:
> From: "bin.yao" <bin.yao@ingenic.com>
>
> Convert the textual documentation for the Ingenic SoCs PDMA Controller
> devicetree binding to YAML.
>
> Signed-off-by: bin.yao <bin.yao@ingenic.com>
> ---
> .../devicetree/bindings/dma/ingenic,pdma.yaml | 67 +++++++++++++++++++
> include/dt-bindings/dma/ingenic-pdma.h | 45 +++++++++++++
> 2 files changed, 112 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/ingenic,pdma.yaml
> create mode 100644 include/dt-bindings/dma/ingenic-pdma.h
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/ingenic,pdma.example.dtb: dma@13420000: $nodename:0: 'dma@13420000' does not match '^dma-controller(@.*)?$'
from schema $id: http://devicetree.org/schemas/dma/ingenic,pdma.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/ingenic,pdma.example.dtb: dma@13420000: 'interrupts-names' is a required property
from schema $id: http://devicetree.org/schemas/dma/ingenic,pdma.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/ingenic,pdma.example.dtb: dma@13420000: Unevaluated properties are not allowed ('interrupt-names' was unexpected)
from schema $id: http://devicetree.org/schemas/dma/ingenic,pdma.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240321080228.24147-2-bin.yao@ingenic.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-03-21 9:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 8:02 [PATCH 1/2] dmaengine: ingenic: add Ingenic PDMA controller support bin.yao
2024-03-21 8:02 ` [PATCH 2/2] dt-bindings: dma: Convert ingenic-pdma doc to YAML bin.yao
2024-03-21 8:30 ` Krzysztof Kozlowski
2024-03-21 9:23 ` Rob Herring [this message]
2024-03-21 8:30 ` [PATCH 1/2] dmaengine: ingenic: add Ingenic PDMA controller support Krzysztof Kozlowski
2024-03-21 8:37 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171101302544.1214225.13077812930159228555.robh@kernel.org \
--to=robh@kernel.org \
--cc=1587636487@qq.com \
--cc=bin.yao@ingenic.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).