From: WeiLiang Lim <weiliang.lim-bONrM45KWFOXmMXjJBpWqg@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Cheehong Ang
<cheehong.ang-bONrM45KWFOXmMXjJBpWqg@public.gmane.org>,
JunLiang Tan
<junliang.tan-bONrM45KWFOXmMXjJBpWqg@public.gmane.org>
Subject: RE: [PATCH] schemas: chosen: Add 'boot-hart-id' property
Date: Thu, 5 Jan 2023 02:06:59 +0000 [thread overview]
Message-ID: <f16051eb110446c8b0cea2e83b418253@EXMBX063.cuchost.com> (raw)
In-Reply-To: <CAL_JsqLaSS=TG23Xh1gPR1ooGBmAgia1c-p7JtAdvsUZskiqNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Tuesday, January 3, 2023 11:22 PM
> To: WeiLiang Lim <weiliang.lim@starfivetech.com>
> Cc: devicetree-spec@vger.kernel.org; Cheehong Ang
> <cheehong.ang@starfivetech.com>; JunLiang Tan
> <junliang.tan@starfivetech.com>
> Subject: Re: [PATCH] schemas: chosen: Add 'boot-hart-id' property
>
> On Mon, Jan 2, 2023 at 9:25 PM Wei Liang Lim
> <weiliang.lim@starfivetech.com> wrote:
> >
> > Add 'boot-hart-id' property to allow user to specify preferred cold boot HART
> in OpenSBI for StarFive JH7110 platform.
>
> The commit message should answer why is this needed, not what is the
> change. Present the problem you are trying to solve with this change, not just
> the solution you came up with.
>
> > Signed-off-by: Wei Liang Lim <weiliang.lim@starfivetech.com>
> > Reviewed-by: Chee Hong Ang <cheehong.ang@starfivetech.com>
> > Reviewed-by: Jun Liang Tan <junliang.tan@starfivetech.com>
> > ---
> > dtschema/schemas/chosen.yaml | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/dtschema/schemas/chosen.yaml
> > b/dtschema/schemas/chosen.yaml index 86194dd..f88feb5 100644
> > --- a/dtschema/schemas/chosen.yaml
> > +++ b/dtschema/schemas/chosen.yaml
> > @@ -31,6 +31,19 @@ properties:
> >
> > bootargs:
> > $ref: types.yaml#/definitions/string
> > +
> > + boot-hart-id:
> > + type: integer
>
> Never the right type for a property.
>
> > + description:
> > + This property allows user to specify preferred cold boot HART in
> OpenSBI
> > + for StarFive JH7110 platform. If unspecified, the existing
> > + lottery mechanism
>
> Specific to StarFive JH7110?
>
> A HART in DT terms is just a CPU, so I think whatever we have should be
> generic. Possibly other arches could use this.
>
> Who consumes this? /chosen is consumed by the OS. When you boot into the
> OS, you already know the boot CPU because it is the one you are running on.
> So this is meant to be consumed by OpenSBI firmware?
>
> Also, read how 'status' is supposed to work for CPUs in the DT spec.
> That didn't get followed for Arm, but could possibly work here. The DT passed
> to OpenSBI has all but the boot CPU disabled and OpenSBI can enable the
> other CPUs. Just guessing since you've given no details of the problem this
> solves...
>
This change is targeted for RISC-V platform which the boot hart is randomly selected through a lottery mechanism by default in OpenSBI (TF-A equivalent on ARM platform). This property is an option for user to select preferred cold boot hart. If unspecified, the default lottery mechanism will be used.
This is mainly to solve some product requirements which a preferred cold boot hart is required.
> > + will be used. e.g.
> > +
> > + /{
> > + chosen {
> > + boot-hart-id = <1>;
> > + };
> > + };
>
> Drop the example.
>
> >
> > kaslr-seed:
> > $ref: types.yaml#/definitions/uint64
> > --
> > 2.25.1
> >
prev parent reply other threads:[~2023-01-05 2:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 3:25 [PATCH] schemas: chosen: Add 'boot-hart-id' property Wei Liang Lim
[not found] ` <20230103032522.36353-1-weiliang.lim-bONrM45KWFOXmMXjJBpWqg@public.gmane.org>
2023-01-03 15:22 ` Rob Herring
[not found] ` <CAL_JsqLaSS=TG23Xh1gPR1ooGBmAgia1c-p7JtAdvsUZskiqNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-01-05 2:06 ` WeiLiang Lim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f16051eb110446c8b0cea2e83b418253@EXMBX063.cuchost.com \
--to=weiliang.lim-bonrm45kwfoxmmxjjbpwqg@public.gmane.org \
--cc=cheehong.ang-bONrM45KWFOXmMXjJBpWqg@public.gmane.org \
--cc=devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=junliang.tan-bONrM45KWFOXmMXjJBpWqg@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).