From: Wolfram Sang <wsa@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: linux-i2c@vger.kernel.org, devicetree-spec@vger.kernel.org,
Andi Shyti <andi.shyti@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: Re: dtschema: i2c: messy situation about timeouts
Date: Mon, 26 Feb 2024 22:16:58 +0100 [thread overview]
Message-ID: <Zdz_ytwYd7A2sGsP@shikoro> (raw)
In-Reply-To: <CAL_JsqKPofALm60XpexAVXj-cYZXyqo-eY0Z+Sx5q4QV0193hw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]
Hi Rob,
> > - "i2c-scl-clk-low-timeout-us"
> >
> > The description says "Number of microseconds the clock line needs to be
> > pulled down in order to force a waiting state." What does "forcing a
> > waiting state" mean here? I don't understand this description.
>
> Does the commit msg or PR help?:
> https://github.com/devicetree-org/dt-schema/pull/103
I checked it beforehand. Sadly, it didn't help me.
> > It is used in the i2c-mpc driver. The use case is simply to put it into
> > the 'struct i2c_adapter.timeout' member. That timeout is used to
> > determine if a transfer failed. So, to me, "i2c-transfer-timeout-us"
> > makes a lot more sense to use here.
> >
> > Suggestion: let's remove this binding and conver i2c-mpc to
> > "i2c-transfer-timeout-us". Yes, not nice to have two deprecated
> > bindings, but things happened.
>
> Maybe the core code should read it instead?
That's an interesting idea. I'll try to implement this tomorrow.
> I think we should mark as deprecated rather than remove unless we can
> just remove the properties from the kernel. The reason being that
You are right. I should have said "depreacte" instead of remove here.
All the best,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-02-26 21:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 10:08 dtschema: i2c: messy situation about timeouts Wolfram Sang
2024-02-26 14:45 ` Rob Herring
2024-02-26 21:16 ` Wolfram Sang [this message]
2024-02-26 20:20 ` Chris Packham
2024-02-26 21:24 ` Wolfram Sang
2024-02-27 0:03 ` Andi Shyti
2024-02-27 7:12 ` Wolfram Sang
2024-02-27 12:57 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zdz_ytwYd7A2sGsP@shikoro \
--to=wsa@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree-spec@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).