From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: "devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Grant Likely <grant.likely-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH] Extract document version from git tag
Date: Thu, 7 Dec 2017 11:01:21 -0600 [thread overview]
Message-ID: <CAL_JsqKs1RLVrsidNG2GEdTj10VmoDGkmrK05X-1-NP4-wtnUw@mail.gmail.com> (raw)
In-Reply-To: <20171207163306.24679-1-grant.likely-5wv7dgnIgG8@public.gmane.org>
On Thu, Dec 7, 2017 at 10:33 AM, Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote:
> Instead of hard coding the document version in the config file, use
> 'git describe' to get the version number from the tags and use that.
> Just like before, if the version string contains a '-', then it is not
> an official release and a watermark will be added to the PDF. This
> catches prereleases "-pre*", untagged revisions "-g<hash>", and
> uncommitted changes "-dirty".
>
> Signed-off-by: Grant Likely <grant.likely-5wv7dgnIgG8@public.gmane.org>
> ---
> source/conf.py | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
Nice!
Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
prev parent reply other threads:[~2017-12-07 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 16:33 [PATCH] Extract document version from git tag Grant Likely
[not found] ` <20171207163306.24679-1-grant.likely-5wv7dgnIgG8@public.gmane.org>
2017-12-07 17:01 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKs1RLVrsidNG2GEdTj10VmoDGkmrK05X-1-NP4-wtnUw@mail.gmail.com \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-5wv7dgnIgG8@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).