From: Michal Simek <michal.simek@xilinx.com>
To: Tom Rini <trini@konsulko.com>,
Michal Simek <michal.simek@xilinx.com>,
Rob Herring <robh@kernel.org>
Cc: devicetree-spec@vger.kernel.org, u-boot@lists.denx.de,
Pierre Aubert <p.aubert@staubli.com>
Subject: Re: [PATCH 01/10] dm: fdt: scan for devices under /firmware too
Date: Wed, 15 Aug 2018 16:50:58 +0200 [thread overview]
Message-ID: <86d61eb1-e038-622b-fe6b-d4a1345619da@xilinx.com> (raw)
In-Reply-To: <20180815143422.GL30947@bill-the-cat>
Hi Rob,
On 15.8.2018 16:34, Tom Rini wrote:
> On Wed, Aug 15, 2018 at 04:30:15PM +0200, Michal Simek wrote:
>> On 15.8.2018 16:17, Tom Rini wrote:
>>> On Mon, Aug 13, 2018 at 05:53:38PM +0200, Jens Wiklander wrote:
>>>
>>>> Just as /chosen may contain devices /firmware may contain devices, scan
>>>> for devices under /firmware too.
>>>>
>>>> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
>>>> ---
>>>> drivers/core/root.c | 15 ++++++++++-----
>>>> 1 file changed, 10 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/drivers/core/root.c b/drivers/core/root.c
>>>> index 72bcc7d7f2a3..0dca507e1187 100644
>>>> --- a/drivers/core/root.c
>>>> +++ b/drivers/core/root.c
>>>> @@ -265,9 +265,15 @@ static int dm_scan_fdt_node(struct udevice *parent, const void *blob,
>>>> for (offset = fdt_first_subnode(blob, offset);
>>>> offset > 0;
>>>> offset = fdt_next_subnode(blob, offset)) {
>>>> - /* "chosen" node isn't a device itself but may contain some: */
>>>> - if (!strcmp(fdt_get_name(blob, offset, NULL), "chosen")) {
>>>> - pr_debug("parsing subnodes of \"chosen\"\n");
>>>> + const char *node_name = fdt_get_name(blob, offset, NULL);
>>>> +
>>>> + /*
>>>> + * The "chosen" and "firmware" nodes aren't devices
>>>> + * themselves but may contain some:
>>>> + */
>>>> + if (!strcmp(node_name, "chosen") ||
>>>> + !strcmp(node_name, "firmware")) {
>>>> + pr_debug("parsing subnodes of \"%s\"\n", node_name);
>>>>
>>>> err = dm_scan_fdt_node(parent, blob, offset,
>>>> pre_reloc_only);
>>>
>>> So, the /firmware node seems special. Have you talked with the
>>> devicetree folks to get it listed in the spec? That would seem rather
>>> valuable for something used by many parties. Thanks!
>>>
>>
>> some days ago we have sent a patch for this too.
>> https://lists.denx.de/pipermail/u-boot/2018-August/338049.html
>>
>> It is using different way but it should do the same thing.
>
> OK, so it sounds like in terms of code clean-ups, we need something like
> what you reference and then some further clean-ups on top of that
> perhaps for other places to call dm_scan_fdt_ofnode_path() for special
> cases. And in terms of formalized specification bits, I do think
> /firmware should perhaps get kicked up to the spec itself so that it's
> very clear to all consumers.
I was also checking latest devicetree spec and there is no record about
/firmware node and how it is supposed to be used.
Thanks,
Michal
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
next parent reply other threads:[~2018-08-15 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180813155347.13844-1-jens.wiklander@linaro.org>
[not found] ` <20180813155347.13844-2-jens.wiklander@linaro.org>
[not found] ` <20180815141726.GI30947@bill-the-cat>
[not found] ` <edcdc49b-8fd0-8862-dc6d-8f66b04be4ba@xilinx.com>
[not found] ` <20180815143422.GL30947@bill-the-cat>
2018-08-15 14:50 ` Michal Simek [this message]
2018-08-15 15:31 ` [PATCH 01/10] dm: fdt: scan for devices under /firmware too Rob Herring
2018-08-15 15:43 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d61eb1-e038-622b-fe6b-d4a1345619da@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=devicetree-spec@vger.kernel.org \
--cc=p.aubert@staubli.com \
--cc=robh@kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).