devicetree-spec.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: "devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [DTSpec PATCH v2] Add items to Devicetree Source Format chapter
Date: Wed, 8 Jun 2016 10:40:27 -0700	[thread overview]
Message-ID: <5758588B.400@gmail.com> (raw)
In-Reply-To: <20160607235013.GP9226-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org>

On 06/07/16 16:50, David Gibson wrote:
> On Tue, Jun 07, 2016 at 01:49:59PM -0700, Frank Rowand wrote:
>> From: Frank Rowand <frank.rowand-mEdOJwZ7QcZBDgjK7y7TUQ@public.gmane.org>
>>
>> Add items to Devicetree Source Format chapter
>>
>> - Add naming convention for DTS files and DTS include files
>> - Add /include/ compiler directive
>> - Add ";" to end of node definition
>> - Add /delete-node/ and /delete-property/
>> - Add arithmetic, bitwise, logical, and ternary expressions
>>
>> Note that cpp directives are not included in this patch, and
>> are not yet specified in this appendix.
>>
>> Signed-off-by: Frank Rowand <frank.rowand-mEdOJwZ7QcZBDgjK7y7TUQ@public.gmane.org>
>> ---
>>
>> changes in v2
>>   - arithmetic operators "and", "or" were incorrectly listed as as bitwise
>>   - thus bitwise operators "and", "or" were incorrectly shown
>>   - "exclusive or" operator added
>>   - logical and arithmetic "not" operators added
>>   - ternary operator added
>>   - moved shift operators from arithmetic to bitwise
>>
>>
>>  source/source-language.rst |   70 ++++++++++++++++++++++++++++++++++++++++++++-
>>  1 file changed, 69 insertions(+), 1 deletion(-)
>>
>> Index: b/source/source-language.rst
>> ===================================================================
>> --- a/source/source-language.rst
>> +++ b/source/source-language.rst
>> @@ -9,6 +9,19 @@ devicetree in the form expected by the k

< snip >

>> +    Logical operators
>> +
>> +    <    less than
>> +    >    greater than
>> +    <=   less than or equal
>> +    >=   greater than or equal
>> +    ==   equal
>> +    !=   not equal
>> +    &&   and
>> +    ||   or
>> +    !    not
> 
> Fwiw, I think &&, || and ! usually get classified as "logical
> operators" but <, > etc. get classified as "relational operators"
> rather than putting them in the same category.

Good point.  I'll send v3 with that change.


> Hrm.. given that you're listing them all here, I wonder if it would
> make sense to do so in precedence order (should be the same as for C).

That seems like a good idea, so I tried it.  The result is a lot less
readable to me.

< snip >

      parent reply	other threads:[~2016-06-08 17:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07 20:49 [DTSpec PATCH v2] Add items to Devicetree Source Format chapter Frank Rowand
     [not found] ` <57573377.4010001-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-07 23:50   ` David Gibson
     [not found]     ` <20160607235013.GP9226-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org>
2016-06-08 17:40       ` Frank Rowand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5758588B.400@gmail.com \
    --to=frowand.list-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
    --cc=devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).