From: Janne Grunau <j@jannau.net>
To: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
"Eric Dumazet" <edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
"Jakub Kicinski" <kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Paolo Abeni" <pabeni-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Krzysztof Kozlowski"
<krzysztof.kozlowski+dt-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Mailing List"
<devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Kalle Valo" <kvalo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"van Spriel" <arend-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
"Jérôme Pouiller"
<jerome.pouiller-S6d6foEdJf7QT0dZR+AlfA@public.gmane.org>,
"Dinh Nguyen" <dinguyen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Ley Foon Tan" <lftan-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>,
"Chee Nouk Phoon"
<cnphoon-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Janne Grunau <j@jannau.net>
Subject: [PATCH v2 4/4] nios2: dts: Fix tse_mac "max-frame-size" property
Date: Sun, 12 Feb 2023 13:16:32 +0100 [thread overview]
Message-ID: <20230203-dt-bindings-network-class-v2-4-499686795073@jannau.net> (raw)
In-Reply-To: <20230203-dt-bindings-network-class-v2-0-499686795073-w2YMFpIX6D+sTnJN9+BGXg@public.gmane.org>
The given value of 1518 seems to refer to the layer 2 ethernet frame
size without 802.1Q tag. Actual use of the "max-frame-size" including in
the consumer of the "altr,tse-1.0" compatible is the MTU.
Fixes: 95acd4c7b69c ("nios2: Device tree support")
Fixes: 61c610ec61bb ("nios2: Add Max10 device tree")
Signed-off-by: Janne Grunau <j@jannau.net>
---
arch/nios2/boot/dts/10m50_devboard.dts | 2 +-
arch/nios2/boot/dts/3c120_devboard.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/nios2/boot/dts/10m50_devboard.dts b/arch/nios2/boot/dts/10m50_devboard.dts
index 56339bef3247..0e7e5b0dd685 100644
--- a/arch/nios2/boot/dts/10m50_devboard.dts
+++ b/arch/nios2/boot/dts/10m50_devboard.dts
@@ -97,7 +97,7 @@ rgmii_0_eth_tse_0: ethernet@400 {
rx-fifo-depth = <8192>;
tx-fifo-depth = <8192>;
address-bits = <48>;
- max-frame-size = <1518>;
+ max-frame-size = <1500>;
local-mac-address = [00 00 00 00 00 00];
altr,has-supplementary-unicast;
altr,enable-sup-addr = <1>;
diff --git a/arch/nios2/boot/dts/3c120_devboard.dts b/arch/nios2/boot/dts/3c120_devboard.dts
index d10fb81686c7..3ee316906379 100644
--- a/arch/nios2/boot/dts/3c120_devboard.dts
+++ b/arch/nios2/boot/dts/3c120_devboard.dts
@@ -106,7 +106,7 @@ tse_mac: ethernet@4000 {
interrupt-names = "rx_irq", "tx_irq";
rx-fifo-depth = <8192>;
tx-fifo-depth = <8192>;
- max-frame-size = <1518>;
+ max-frame-size = <1500>;
local-mac-address = [ 00 00 00 00 00 00 ];
phy-mode = "rgmii-id";
phy-handle = <&phy0>;
--
2.39.1
next prev parent reply other threads:[~2023-02-12 12:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 12:16 [PATCH v2 0/4] dt-bindings: net: Add network-class.yaml schema Janne Grunau
[not found] ` <20230203-dt-bindings-network-class-v2-0-499686795073-w2YMFpIX6D+sTnJN9+BGXg@public.gmane.org>
2023-02-12 12:16 ` [PATCH v2 1/4] dt-bindings: net: Add network-class schema for mac-address properties Janne Grunau
[not found] ` <20230203-dt-bindings-network-class-v2-1-499686795073-w2YMFpIX6D+sTnJN9+BGXg@public.gmane.org>
2023-02-12 15:39 ` Andrew Lunn
2023-02-12 12:16 ` [PATCH v2 2/4] dt-bindings: wireless: bcm4329-fmac: Use network-class.yaml schema Janne Grunau
[not found] ` <20230203-dt-bindings-network-class-v2-2-499686795073-w2YMFpIX6D+sTnJN9+BGXg@public.gmane.org>
2023-02-12 15:49 ` Andrew Lunn
2023-02-12 12:16 ` [PATCH v2 3/4] dt-bindings: wireless: silabs,wfx: Use network-class.yaml Janne Grunau
2023-02-12 12:16 ` Janne Grunau [this message]
[not found] ` <20230203-dt-bindings-network-class-v2-4-499686795073-w2YMFpIX6D+sTnJN9+BGXg@public.gmane.org>
2023-02-16 15:54 ` [PATCH v2 4/4] nios2: dts: Fix tse_mac "max-frame-size" property Dinh Nguyen
2023-02-20 19:40 ` [PATCH v2 0/4] dt-bindings: net: Add network-class.yaml schema Jakub Kicinski
[not found] ` <20230220114016.71628270-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-02-20 21:49 ` Rob Herring
[not found] ` <CAL_Jsq+2_gQzAjAZQVux1GOff5ocdSz5qQMhjRzvtyD+9C-TQQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-02-20 22:02 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203-dt-bindings-network-class-v2-4-499686795073@jannau.net \
--to=j@jannau.net \
--cc=arend-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=cnphoon-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dinguyen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=jerome.pouiller-S6d6foEdJf7QT0dZR+AlfA@public.gmane.org \
--cc=krzysztof.kozlowski+dt-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=kvalo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=lftan-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pabeni-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).