From: Tom Rini <trini-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Bill Mills <bill.mills-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] Add Github Action CI workflow
Date: Thu, 17 Jun 2021 18:31:05 -0400 [thread overview]
Message-ID: <20210617223105.GQ9516@bill-the-cat> (raw)
In-Reply-To: <CAL_JsqJrvFUiqL_ehzbU3r8M+PfcjbL7Bx8a4afWN3F6-xFLbg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2764 bytes --]
On Thu, Jun 17, 2021 at 04:24:12PM -0600, Rob Herring wrote:
> On Thu, Jun 17, 2021 at 1:19 PM Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
> >
> > Hi Rob,
> >
> > On Mon, 14 Jun 2021 at 11:36, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > >
> > > Travis-ci.org is going away and moving to Travis-ci.com requires some
> > > work. It would probably involve fixing authentication issues yet again.
> > > Instead, let's just move to a GH actions job which is fairly trivial to
> > > setup. This has the side benefit of CI will run on anyone's fork without
> > > further setup.
> > >
> > > As part of this, the specification file name gains a 'git-describe'
> > > based version number.
> > >
> > > Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > > ---
> > > .github/workflows/ci.yml | 60 ++++++++++++++++++++++++++++++++++++++++
> > > 1 file changed, 60 insertions(+)
> > > create mode 100644 .github/workflows/ci.yml
> >
> > Reviewed-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>
> Thanks for looking.
>
> >
> > Questions below
> >
> > >
> > > diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
> > > new file mode 100644
> > > index 000000000000..f8fe08d52cb0
> > > --- /dev/null
> > > +++ b/.github/workflows/ci.yml
> > > @@ -0,0 +1,60 @@
> > > +name: Github Action CI
> > > +
> > > +on:
> > > + push:
> > > + branches:
> > > + - '*'
> > > + tags:
> > > + - 'v*'
> > > + pull_request:
> > > + branches:
> > > + master
> > > +
> > > +jobs:
> > > + build:
> > > + runs-on: ubuntu-latest
> > > +
> > > + steps:
> > > + - uses: actions/checkout@v2
> > > + with:
> > > + fetch-depth: 0
> > > +
> > > + - name: install
> > > + run: |
> > > + sudo apt-get update
> > > + sudo apt-get install latexmk libalgorithm-diff-perl texlive texlive-latex-extra texlive-humanities graphviz
> > > + pip3 install --user mako
> > > + pip3 install --user typing
> > > + pip3 install --user Sphinx
> >
> > Does this need the capital S ?
>
> I believe so. This is copy-paste from the TravisCI job.
>
> > Can we use apt install instead?
>
> Perhaps. I think the issue here was the TravisCI using ancient ubuntu
> versions and we needed a newer version of Sphinx at some point. GH is
> the latest LTS, so it should be new enough.
On a slight tangent, perhaps a requirements.txt so that in CI you just:
pip3 install --user --requirement path/to/requirements.txt
and as a bonus it documents what modules someone needs to build outside
of CI and future module needs are handled without a CI change.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2021-06-17 22:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 17:36 [PATCH] Add Github Action CI workflow Rob Herring
[not found] ` <20210614173623.1125220-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2021-06-17 19:18 ` Simon Glass
[not found] ` <CAPnjgZ27P9mXRBzcHeoVHF1OyLqS95NnJQ7dAvNnhMf-6XUa-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-06-17 22:24 ` Rob Herring
[not found] ` <CAL_JsqJrvFUiqL_ehzbU3r8M+PfcjbL7Bx8a4afWN3F6-xFLbg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-06-17 22:31 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617223105.GQ9516@bill-the-cat \
--to=trini-owpks81ov/fwk0htik3j/w@public.gmane.org \
--cc=bill.mills-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=devicetree-spec-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).