From: David Gibson <david@gibson.dropbear.id.au>
To: Charles Perry <charles.perry@savoirfairelinux.com>
Cc: devicetree-compiler@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dtc: ensure that command line options arrays length match
Date: Thu, 25 Jan 2024 14:45:25 +1100 [thread overview]
Message-ID: <ZbHZVVsXh8M16frL@zatzit> (raw)
In-Reply-To: <20230904143104.1941715-2-charles.perry@savoirfairelinux.com>
[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]
On Mon, Sep 04, 2023 at 07:31:04AM -0700, Charles Perry wrote:
> usage_long_opts and usage_opts_help should always have the same length.
> Since these are fixed length arrays, this can be checked at compile time
> with _Static_assert (requires C11).
Sorry I've taken so long to reply.
I like the idea here, and I'm ok with C11 being required for dtc
(although I'd prefer to keep libfdt to c99). But, because this does
introduce a new dependency I'd like to see it come after a patch
making that a bit more formal - adding compiler flags to enforce it,
for example.
> Signed-off-by: Charles Perry <charles.perry@savoirfairelinux.com>
> ---
> dtc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/dtc.c b/dtc.c
> index 0655c2e..1f38b97 100644
> --- a/dtc.c
> +++ b/dtc.c
> @@ -112,6 +112,8 @@ static const char * const usage_opts_help[] = {
> "\n\tPrint version and exit",
> NULL,
> };
> +_Static_assert(ARRAY_SIZE(usage_long_opts) == ARRAY_SIZE(usage_opts_help),
> + "usage_long_opts and usage_opts_help length differ");
Also, IIUC, C11 also requires the less ugly 'static_assert' macro
which amounts to the same thing.
>
> static const char *guess_type_by_name(const char *fname, const char *fallback)
> {
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-01-25 3:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 14:31 [PATCH v2 1/2] dtc: fix missing string in usage_opts_help Charles Perry
[not found] ` <20230904143104.1941715-1-charles.perry-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
2023-09-04 14:31 ` [PATCH v2 2/2] dtc: ensure that command line options arrays length match Charles Perry
2024-01-25 3:45 ` David Gibson [this message]
2023-09-05 2:00 ` [PATCH v2 1/2] dtc: fix missing string in usage_opts_help David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbHZVVsXh8M16frL@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=charles.perry@savoirfairelinux.com \
--cc=devicetree-compiler@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).