From: David Gibson <david@gibson.dropbear.id.au>
To: Alyssa Ross <hi@alyssa.is>
Cc: devicetree-compiler@vger.kernel.org
Subject: Re: [PATCH] tests: use correct pkg-config when cross compiling
Date: Thu, 25 Jan 2024 13:31:46 +1100 [thread overview]
Message-ID: <ZbHIEp5s-ZJ-kFG4@zatzit> (raw)
In-Reply-To: <20240123130409.181128-2-hi@alyssa.is>
[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]
On Tue, Jan 23, 2024 at 02:04:10PM +0100, Alyssa Ross wrote:
> By convention, the PKG_CONFIG environment variable is used to tell
> build systems which pkg-config executable should be used. This is
> often used when cross compiling, where it might be set to something
> like "aarch64-unknown-linux-gnu-pkg-config".
>
> Signed-off-by: Alyssa Ross <hi@alyssa.is>
Applied, thanks.
> ---
> tests/run_tests.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/run_tests.sh b/tests/run_tests.sh
> index bb2ec95..3225a12 100755
> --- a/tests/run_tests.sh
> +++ b/tests/run_tests.sh
> @@ -32,7 +32,7 @@ if [ -n "$NO_YAML" ]; then
> no_yaml=false
> fi
> else
> - if pkg-config --atleast-version 0.2.3 yaml-0.1; then
> + if ${PKG_CONFIG:-pkg-config} --atleast-version 0.2.3 yaml-0.1; then
> no_yaml=false
> else
> no_yaml=true
>
> base-commit: 95c74d71f0904235d44892627322f60a18c9a28c
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-01-25 3:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 13:04 [PATCH] tests: use correct pkg-config when cross compiling Alyssa Ross
2024-01-25 2:31 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbHIEp5s-ZJ-kFG4@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=hi@alyssa.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).