From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Luca Weiss <luca-IfPCFPJWly+lVyrhU4qvOw@public.gmane.org>
Cc: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Devicetree Compiler
<devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 4/4] pylibfdt: add FdtRo.getprop_or_none()
Date: Tue, 25 Jan 2022 15:50:29 +1100 [thread overview]
Message-ID: <Ye+BlawkG7LK6ZkF@yekko> (raw)
In-Reply-To: <5532817.DvuYhMxLoT@g550jk>
[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]
On Sat, Jan 22, 2022 at 11:36:01AM +0100, Luca Weiss wrote:
> Hi Simon,
>
> On Dienstag, 28. Dezember 2021 09:34:57 CET Simon Glass wrote:
> > Hi Luca,
> >
> > On Sat, 25 Dec 2021 at 06:26, Luca Weiss <luca-IfPCFPJWly+lVyrhU4qvOw@public.gmane.org> wrote:
> > > Add a new method that doesn't throw an exception when a property isn't
> > > found but returns None instead.
> > >
> > > Also add a test for the new method.
> >
> > You can use
> >
> > getprop(node, prop, quiet=QUIET_NOTFOUND)
> >
>
> This returns -1 when not found which I found quite un-pythonic (not that
> pylibfdt is currently super pythonic ;) ).
> Having None returned if not found is much nicer to use and much more clear to
> use
>
> if foobar is None:
>
> instead of having to use
>
> if foobar == -QUIET_NOTFOUND:
>
>
> Are there any changes I can do for you to reconsider your position on this
> patch?
So, you're absolutely right that the current interface is
non-pythonic. The question is simply whether that ugliness is enough
to outweight the complexity of introducing an extra interface.
>
> Regards
> Luca
>
> > > Signed-off-by: Luca Weiss <luca-IfPCFPJWly+lVyrhU4qvOw@public.gmane.org>
> > > ---
> > >
> > > pylibfdt/libfdt.i | 10 ++++++++++
> > > tests/pylibfdt_tests.py | 2 ++
> > > 2 files changed, 12 insertions(+)
> >
> > Regards,
> > Simon
>
>
>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-01-25 4:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-25 13:25 [PATCH 0/4] Add new helpers to pylibfdt Luca Weiss
[not found] ` <20211225132558.167123-1-luca-IfPCFPJWly+lVyrhU4qvOw@public.gmane.org>
2021-12-25 13:25 ` [PATCH 1/4] pylibfdt: add Property.as_stringlist() Luca Weiss
[not found] ` <20211225132558.167123-2-luca-IfPCFPJWly+lVyrhU4qvOw@public.gmane.org>
2021-12-28 4:29 ` David Gibson
2022-01-05 22:48 ` Rob Herring
[not found] ` <CAL_JsqLvQdm1kqMED8G03LEsm+xgyY2A+F+FD8DYeAy5o+eiGg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-01-18 10:08 ` David Gibson
2022-01-20 19:24 ` Luca Weiss
2022-01-21 0:12 ` David Gibson
2021-12-25 13:25 ` [PATCH 2/4] pylibfdt: add Property.as_*int*_array() Luca Weiss
[not found] ` <20211225132558.167123-3-luca-IfPCFPJWly+lVyrhU4qvOw@public.gmane.org>
2021-12-28 4:30 ` David Gibson
2021-12-25 13:25 ` [PATCH 3/4] pylibfdt: add FdtRo.get_path() Luca Weiss
[not found] ` <20211225132558.167123-4-luca-IfPCFPJWly+lVyrhU4qvOw@public.gmane.org>
2021-12-28 4:33 ` David Gibson
2021-12-25 13:25 ` [PATCH 4/4] pylibfdt: add FdtRo.getprop_or_none() Luca Weiss
[not found] ` <20211225132558.167123-5-luca-IfPCFPJWly+lVyrhU4qvOw@public.gmane.org>
2021-12-28 5:20 ` David Gibson
2021-12-28 8:34 ` Simon Glass
[not found] ` <CAPnjgZ3wun92Q1vMSEem9CH6A8MWNbKZNaepf4j4Ttmf-GNPtQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-01-22 10:36 ` Luca Weiss
2022-01-24 17:57 ` Simon Glass
[not found] ` <CAPnjgZ1NX2Q884T_LNUOLJT8=RKZXEj2z7uxzQF4MrHiKObZvA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-01-24 20:50 ` Luca Weiss
2022-01-24 21:28 ` Simon Glass
2022-01-25 4:50 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ye+BlawkG7LK6ZkF@yekko \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=luca-IfPCFPJWly+lVyrhU4qvOw@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).