From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Andre Przywara <andre.przywara-5wv7dgnIgG8@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH v3 5/5] Makefile: add -Wsign-compare to warning options
Date: Mon, 21 Jun 2021 15:35:21 +1000 [thread overview]
Message-ID: <YNAlGad2CNxD8q7g@yekko> (raw)
In-Reply-To: <20210618172030.9684-6-andre.przywara-5wv7dgnIgG8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
On Fri, Jun 18, 2021 at 06:20:30PM +0100, Andre Przywara wrote:
> Now that all signedness comparison warnings in the source tree have been
> fixed, let's enable the warning option, to avoid them creeping in again.
>
> Signed-off-by: Andre Przywara <andre.przywara-5wv7dgnIgG8@public.gmane.org>
Applied, thanks.
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index ea8c659..ee77115 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -21,7 +21,7 @@ CONFIG_LOCALVERSION =
> ASSUME_MASK ?= 0
>
> CPPFLAGS = -I libfdt -I . -DFDT_ASSUME_MASK=$(ASSUME_MASK)
> -WARNINGS = -Wall -Wpointer-arith -Wcast-qual -Wnested-externs \
> +WARNINGS = -Wall -Wpointer-arith -Wcast-qual -Wnested-externs -Wsign-compare \
> -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wshadow
> CFLAGS = -g -Os $(SHAREDLIB_CFLAGS) -Werror $(WARNINGS) $(EXTRA_CFLAGS)
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-06-21 5:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 17:20 [PATCH v3 0/5] dtc: Fix signed/unsigned comparison warnings Andre Przywara
[not found] ` <20210618172030.9684-1-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2021-06-18 17:20 ` [PATCH v3 1/5] tests: Fix signedness comparisons warnings Andre Przywara
[not found] ` <20210618172030.9684-2-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2021-06-21 5:26 ` David Gibson
2021-06-18 17:20 ` [PATCH v3 2/5] fdtget: " Andre Przywara
[not found] ` <20210618172030.9684-3-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2021-06-21 5:27 ` David Gibson
2021-06-18 17:20 ` [PATCH v3 3/5] dtc: Wrap phandle validity check Andre Przywara
[not found] ` <20210618172030.9684-4-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2021-06-21 5:28 ` David Gibson
2021-06-18 17:20 ` [PATCH v3 4/5] checks: Fix signedness comparisons warnings Andre Przywara
[not found] ` <20210618172030.9684-5-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2021-06-21 5:34 ` David Gibson
2021-06-18 17:20 ` [PATCH v3 5/5] Makefile: add -Wsign-compare to warning options Andre Przywara
[not found] ` <20210618172030.9684-6-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2021-06-21 5:35 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNAlGad2CNxD8q7g@yekko \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=andre.przywara-5wv7dgnIgG8@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).