From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: "Marc-André Lureau"
<marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Devicetree Compiler
<devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 5/5] build-sys: replace makefiles to wrap meson/ninja
Date: Sat, 19 Jun 2021 19:31:19 +1000 [thread overview]
Message-ID: <YM25ZwrpjOMpef5u@yekko> (raw)
In-Reply-To: <CAMxuvaw2GoT-3CrTmBsiR==N2ZV3yJ--5MeN58DPypbJPrkfHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 4320 bytes --]
On Tue, Jun 15, 2021 at 11:19:39AM +0400, Marc-André Lureau wrote:
> Hi
>
> On Tue, Jun 15, 2021 at 10:26 AM David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6iEOx6SR5NKn@public.gmane.orgu>
> wrote:
>
> > On Tue, Jun 08, 2021 at 01:25:03PM +0400, Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Tue, Jun 8, 2021 at 7:54 AM David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6ryscVyMRj84@public.gmane.org.au
> > >
> > > wrote:
> > >
> > > > On Mon, Dec 07, 2020 at 05:00:55PM +0400, marcandre.lureau@redhat.com
> > > > wrote:
> > > > > From: Marc-André Lureau <marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > > > >
> > > > > This avoids maintaining two build systems, and update the
> > documentation.
> > > > >
> > > > > Makefile now wrap meson, so that make all/check/checkm/clean/install
> > > > > continue working as they used to.
> > > > >
> > > > > Signed-off-by: Marc-André Lureau <marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > > >
> > > > Sorry I've neglected this so long. I finally got around to lookup up
> > > > a cheatsheet for how to use meson "natively" to understand this
> > > > better.
> > > >
> > > > Couple of issues with this path though:
> > > >
> > > > > ---
> > > > > Makefile | 380
> > ++-----------------------------------
> > > > > Makefile.convert-dtsv0 | 14 --
> > > > > Makefile.dtc | 23 ---
> > > > > Makefile.utils | 31 ---
> > > > > README | 24 ++-
> > > > > libfdt/Makefile.libfdt | 18 --
> > > > > pylibfdt/Makefile.pylibfdt | 30 ---
> > > > > tests/Makefile.tests | 100 ----------
> > > >
> > > > First, it no longer applies clean due to some added tests. Can you
> > > > rebase please.
> > > >
> > >
> > > Sure, https://github.com/elmarco/dtc/tree/meson-next
> > >
> > >
> > > > > +checkm:
> > > > > + WITH_VALGRIND=1 meson test -C $(BUILD_DIR) -v
> > > >
> > > > Second, the valgrind stuff doesn't seem to work. I tried
> > > > "WITH_VALGRIND=1 meson test" and it completes much to fast to actually
> > > > be using valgrind. Also it doesn't give any error if valgrind isn't
> > > > installed.
> > > >
> > >
> > > Oh? I get this:
> > > /home/elmarco/src/dtc/tests/run_tests.sh: line 75: valgrind: command not
> > > found
> > >
> > > And when valgrind is installed it uses it and takes ages to complete the
> > > tests.
> >
> > Huh. Yet for me it does not
> >
> > yekko:~/src/dtc/tmp (main)$ time meson test
> > ninja: Entering directory `/home/dwg/src/dtc/tmp'
> > [2/2] Generating pylibfdt with a custom command
> > 1/1 run-test OK 2.67s
> >
> >
> > Ok: 1
> > Expected Fail: 0
> > Fail: 0
> > Unexpected Pass: 0
> > Skipped: 0
> > Timeout: 0
> >
> > Full log written to /home/dwg/src/dtc/tmp/meson-logs/testlog.txt
> >
> > real 0m3.015s
> > user 0m1.862s
> > sys 0m1.197s
> > yekko:~/src/dtc/tmp (main)$ time env WITH_VALGRIND=1 meson test
> > ninja: Entering directory `/home/dwg/src/dtc/tmp'
> > [2/2] Generating pylibfdt with a custom command
> > 1/1 run-test OK 2.47s
> >
> >
> > Ok: 1
> > Expected Fail: 0
> > Fail: 0
> > Unexpected Pass: 0
> > Skipped: 0
> > Timeout: 0
> >
> > Full log written to /home/dwg/src/dtc/tmp/meson-logs/testlog.txt
> >
> > real 0m2.836s
> > user 0m1.838s
> > sys 0m1.163s
> >
> >
> > I have no idea how to debug that...
> >
> >
> What's your version of meson? There has been an environment-related
> regression in 0.58 that was quickly fixed in 0.58.1. (I tried older
> versions as well when I wrote the patch last year)
meson-0.56.2-2.fc34.noarch
ninja-build-1.10.2-2.fc34.x86_64
> You could check your environment by adding an "env" call at the top of
> run_tests.sh and checking it in build/meson-logs/testlog.txt
Tried that, and it showed the WITH_VALGRIND value. I'm not actually
sure what's supposed to be acting on the WITH_VALGRIND variable.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-06-19 9:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 13:00 [PATCH 0/5] Follow-up on meson marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA
[not found] ` <20201207130055.462734-1-marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-12-07 13:00 ` [PATCH 1/5] meson: fix -Wall warning marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA
2020-12-07 13:00 ` [PATCH 2/5] meson: do not assume python is installed, skip tests marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA
2020-12-07 13:00 ` [PATCH 3/5] meson: increase default timeout for tests marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA
2020-12-07 13:00 ` [PATCH 4/5] travis: install meson marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA
[not found] ` <20201207130055.462734-5-marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2021-06-08 3:54 ` David Gibson
[not found] ` <CAMxuvax=yjONOpay9+CvYvV88MKFu84W8w0SpiDyg3GuQaHA0g@mail.gmail.com>
[not found] ` <CAMxuvax=yjONOpay9+CvYvV88MKFu84W8w0SpiDyg3GuQaHA0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-06-10 5:28 ` David Gibson
2020-12-07 13:00 ` [PATCH 5/5] build-sys: replace makefiles to wrap meson/ninja marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA
[not found] ` <20201207130055.462734-6-marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2021-06-08 3:54 ` David Gibson
[not found] ` <CAMxuvaxcwrDiuxKizMjkXZFy6K3X0TSN-Z-=+SNXe53j1pMr1A@mail.gmail.com>
[not found] ` <CAMxuvaxcwrDiuxKizMjkXZFy6K3X0TSN-Z-=+SNXe53j1pMr1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-06-15 5:58 ` David Gibson
[not found] ` <CAMxuvaw2GoT-3CrTmBsiR==N2ZV3yJ--5MeN58DPypbJPrkfHQ@mail.gmail.com>
[not found] ` <CAMxuvaw2GoT-3CrTmBsiR==N2ZV3yJ--5MeN58DPypbJPrkfHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-06-19 9:31 ` David Gibson [this message]
2020-12-08 4:33 ` [PATCH 0/5] Follow-up on meson David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YM25ZwrpjOMpef5u@yekko \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).