From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Bin Meng <bmeng.cn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Fangrui Song <maskray-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] libfdt: Fix the undefined behavior in fdt_num_mem_rsv()
Date: Tue, 20 Apr 2021 11:30:09 +1000 [thread overview]
Message-ID: <YH4uoWoR+6IBB9sh@yekko.fritz.box> (raw)
In-Reply-To: <CAEUhbmWeTpRHPdqMtcNWdF-ORJ0OXcMi1YJeN+KUpbkqGKvFGg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 6941 bytes --]
On Thu, Apr 08, 2021 at 11:21:52AM +0800, Bin Meng wrote:
65;6203;1c> Hi David,
>
> On Thu, Apr 8, 2021 at 10:59 AM David Gibson
> <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org> wrote:
> >
> > On Fri, Apr 02, 2021 at 12:52:43PM +0800, Bin Meng wrote:
> > > Hi David,
> > >
> > > On Thu, Apr 1, 2021 at 12:30 PM David Gibson
> > > <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org> wrote:
> > > >
> > > > On Tue, Mar 30, 2021 at 05:56:45PM +0800, Bin Meng wrote:
> > > > > With LLVM 10.0.0+, the following codes in fdt_num_mem_rsv() does not
> > > > > work any more for an fdt that is at address 0:
> > > > >
> > > > > for (i = 0; (re = fdt_mem_rsv(fdt, i)) != NULL; i++) {
> > > > > if (fdt64_ld_(&re->size) == 0)
> > > > > return i;
> > > > > }
> > > > >
> > > > > Due to LLVM's optimization engine utilizing a UB in C, the following
> > > > > code pattern:
> > > > >
> > > > > if ((pointer + offset) != NULL)
> > > > >
> > > > > is transformed into:
> > > > >
> > > > > if (pointer != NULL)
> > > > >
> > > > > because if pointer is NULL and offset is non-zero, the result of
> > > > > (pointer + offset) is UB. So LLVM is free to exploit such UB to
> > > > > perform some optimization.
> > > > >
> > > > > In this case, fdt_mem_rsv() gets inlined and returns (pointer + offset).
> > > > > And LLVM in turns emits codes to check fdt against NULL, which won't
> > > > > work for fdt at address 0.
> > > >
> > > > I don't think this really fixes anything. It might fool LLVM into
> > > > doing what you need right now, but I don't see any reason to expect it
> > > > will keep doing so.
> > >
> > > This specific UB optimizer changes [1] have been merged in LLVM for at
> > > least 1.5 years, and it has been there since LLVM 10/11.
> >
> > Ok, but that doesn't change the basic fact that this is just fooling
> > the compiler into behaving differently - it doesn't actually remove
> > the UB.
>
> As I explained, it removes the pre-condition of the UB optimizer
> effect. The UB of (pointer + offset) when pointer is NULL, is safe as
> long as it is not in the statement of flow control.
Yes, I understand what it's doing. But the fact remains you're not
"fixing" any UB at all - the exact same UB is still there, you're just
working around the specific behaviour of LLVM's optimizer.
>
> >
> > > > IIUC, you're saying that the specific problem is that adding a
> > > > non-zero offset to a NULL pointer is UB, which happens inside
> > > > fdt_mem_rsv_() if n != 0. But with your patch, that UB still exists..
> > > >
> > >
> > > The UB exists only when the fdt pointer is NULL.
> >
> > Yes...
> >
> > > > > Signed-off-by: Bin Meng <bmeng.cn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > > > ---
> > > > >
> > > > > libfdt/fdt_ro.c | 17 +++++++++++++----
> > > > > 1 file changed, 13 insertions(+), 4 deletions(-)
> > > > >
> > > > > diff --git a/libfdt/fdt_ro.c b/libfdt/fdt_ro.c
> > > > > index 17584da..4db4013 100644
> > > > > --- a/libfdt/fdt_ro.c
> > > > > +++ b/libfdt/fdt_ro.c
> > > > > @@ -157,18 +157,26 @@ int fdt_generate_phandle(const void *fdt, uint32_t *phandle)
> > > > > return 0;
> > > > > }
> > > > >
> > > > > -static const struct fdt_reserve_entry *fdt_mem_rsv(const void *fdt, int n)
> > > > > +static bool fdt_is_mem_rsv(const void *fdt, int n)
> > > > > {
> > > > > unsigned int offset = n * sizeof(struct fdt_reserve_entry);
> > > > > unsigned int absoffset = fdt_off_mem_rsvmap(fdt) + offset;
> > > > >
> > > > > if (!can_assume(VALID_INPUT)) {
> > > > > if (absoffset < fdt_off_mem_rsvmap(fdt))
> > > > > - return NULL;
> > > > > + return false;
> > > > > if (absoffset > fdt_totalsize(fdt) -
> > > > > sizeof(struct fdt_reserve_entry))
> > > > > - return NULL;
> > > > > + return false;
> > > > > }
> > > > > +
> > > > > + return true;
> > > > > +}
> > > > > +
> > > > > +static const struct fdt_reserve_entry *fdt_mem_rsv(const void *fdt, int n)
> > > > > +{
> > > > > + if (!fdt_is_mem_rsv(fdt, n))
> > > > > + return NULL;
> > > > > return fdt_mem_rsv_(fdt, n);
> > > > > }
> > > > >
> > > > > @@ -191,7 +199,8 @@ int fdt_num_mem_rsv(const void *fdt)
> > > > > int i;
> > > > > const struct fdt_reserve_entry *re;
> > > > >
> > > > > - for (i = 0; (re = fdt_mem_rsv(fdt, i)) != NULL; i++) {
> > > > > + for (i = 0; fdt_is_mem_rsv(fdt, i); i++) {
> > > > > + re = fdt_mem_rsv_(fdt, i);
> > > >
> > > > .. here ^^.
> > > >
> > > >
> > > > Basically if your compiled is going to optimized based on (NULL +
> > > > something) being UB, and the NULL pointer is address 0, that's
> > > > fundamentally incompatible with storing a device tree at address 0.
> > >
> > > As long as we don't put (pointer + offset) into a statement of flow
> > > control, it is fine. You can still get the correct value of (pointer +
> > > offset) when pointer is NULL and yes, it is still a UB but we can
> > > expect such usage is safe.
> >
> > People always say that about UB until it isn't. This is just way to
> > subtle a distinction for me to be comfortable relying on it.
> >
> > Fundamentally the problem is that you want to store your fdt at
> > address zero, but that is just not compatible with your compiler,
>
> I am not sure it is a compatibility issue when language layers were
> defining the C spec without considering the fact that RAM address zero
> is absolutely OK on some systems. In normal programming environment we
> don't store data at address zero so NULL can be used as an indication
> of invalid pointer, but this practice may not apply on low-level
> environment like for example, when bootloader passes the FDT at
> address zero for kernel to handle it, or a bootloader environment
> where FDT is placed at a ROM address 0 ...
Yes. A C implementation using address 0 as a NULL pointer is
incompatible with manipulating real data at address 0; that's exactly
what I'm saying. Historically people have gotten away with it because
the compiler hasn't usually optimized this way, but as compilers get
smarter it has broken.
This change is just a really non-obvious workaround for a specific
compiler optimizer.
To fix this properly you need to either:
* Use asm code to copy the fdt to a different address, then use C
or
* Tell your compiler to be dumber and not apply this optimization.
> > since it considers that a NULL pointer.
>
> Regards,
> Bin
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-04-20 1:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 9:56 [PATCH] libfdt: Fix the undefined behavior in fdt_num_mem_rsv() Bin Meng
[not found] ` <20210330095645.515056-1-bmeng.cn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-04-01 3:25 ` David Gibson
[not found] ` <YGU9FH3WccMBrfl1-l+x2Y8Cxqc4e6aEkudXLsA@public.gmane.org>
2021-04-02 4:52 ` Bin Meng
[not found] ` <CAEUhbmVsszFcUC8tEYmJ4djPvyDmXspDg-gb9rYZpm8zWwxc1g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-04-08 2:54 ` David Gibson
[not found] ` <YG5wZa/ti6klXEZQ-l+x2Y8Cxqc4e6aEkudXLsA@public.gmane.org>
2021-04-08 3:21 ` Bin Meng
[not found] ` <CAEUhbmWeTpRHPdqMtcNWdF-ORJ0OXcMi1YJeN+KUpbkqGKvFGg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-04-20 1:30 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH4uoWoR+6IBB9sh@yekko.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=bmeng.cn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maskray-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).