From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Masahiro Yamada <masahiroy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Viresh Kumar
<viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] dtc: Remove -O dtbo support
Date: Fri, 12 Mar 2021 12:58:09 +1100 [thread overview]
Message-ID: <YErKscWisdaJf/PE@yekko.fritz.box> (raw)
In-Reply-To: <20210311094956.924310-1-masahiroy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]
On Thu, Mar 11, 2021 at 06:49:55PM +0900, Masahiro Yamada wrote:
> This partially reverts 163f0469bf2e ("dtc: Allow overlays to have
> .dtbo extension").
>
> I think accepting "dtbo" as --out-format is strange. This is not
> shown by --help, at least.
>
> *.dtb and *.dtbo should have the same format, "dtb".
>
> Signed-off-by: Masahiro Yamada <masahiroy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Oops, yes. When reviewing 163f0469bf2e I missed the fact that it
accepted -O dtbo as well changing the default based on file extension.
Applied.
> ---
>
> dtc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/dtc.c b/dtc.c
> index 838c5df..3962d3f 100644
> --- a/dtc.c
> +++ b/dtc.c
> @@ -359,8 +359,6 @@ int main(int argc, char *argv[])
> #endif
> } else if (streq(outform, "dtb")) {
> dt_to_blob(outf, dti, outversion);
> - } else if (streq(outform, "dtbo")) {
> - dt_to_blob(outf, dti, outversion);
> } else if (streq(outform, "asm")) {
> dt_to_asm(outf, dti, outversion);
> } else if (streq(outform, "null")) {
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-03-12 1:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 9:49 [PATCH] dtc: Remove -O dtbo support Masahiro Yamada
[not found] ` <20210311094956.924310-1-masahiroy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2021-03-12 1:58 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YErKscWisdaJf/PE@yekko.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=masahiroy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).