From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Ryan Long
<thisisryanlong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Devicetree Compiler
<devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Ryan Long <ryan.long-lGxtRh3/QYtBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] Unchecked return value error in fdt_rw.c
Date: Wed, 3 Mar 2021 19:33:52 +1100 [thread overview]
Message-ID: <YD9J8OVvACNd4ppy@yekko.fritz.box> (raw)
In-Reply-To: <CAL_JsqK68HjwdT5+-kjo3Yr7XokC=6ioa7dkMzeUsve8iEzVxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]
On Mon, Mar 01, 2021 at 08:29:49PM -0600, Rob Herring wrote:
> On Mon, Mar 1, 2021 at 4:27 PM Ryan Long <thisisryanlong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >
> > Hi,
> >
> > I filed an issue on github, but I was told it'd be good to send this to
> > the mailing list as well.
> >
> > RTEMS (RTEMS.org) is a free single process, multi-threaded real-time operating
> > system with a long history. Your dtc toolchain has been incorporated into
> > RTEMS. The RTEMS Project is a member of the Coverity Scan program and it
> > flagged an issue with /dtc/libfdt/fdt_rw.c. In trying to be good citizens of
> > the wider open source community, the project wants these issues to be reported
> > to the upstream owner along with a fix or suggestions. This is one of those
> > reports.
> >
> > When Coverity Scan was ran on some of your code, a "Unchecked return value"
> > error was found at line 352 in fdt_rw.c. For similar errors that we received
> > for RTEMS, we created a macro that will assert the value returned and "use" the
> > return value like so.
>
> Humm, I think Coverity scans run on the Linux kernel too, but I've
> never seen any reports on the kernel's copy. Just wondering why...
It runs on dtc upstream as well.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-03-03 8:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 22:24 [PATCH] Unchecked return value error in fdt_rw.c Ryan Long
[not found] ` <1614637450-4972-1-git-send-email-ryan.long-lGxtRh3/QYtBDgjK7y7TUQ@public.gmane.org>
2021-03-01 22:24 ` [PATCH] fdt_rw.c: Fix Unchecked return value error Ryan Long
[not found] ` <1614637450-4972-2-git-send-email-ryan.long-lGxtRh3/QYtBDgjK7y7TUQ@public.gmane.org>
2021-03-02 2:26 ` Rob Herring
2021-03-02 2:29 ` [PATCH] Unchecked return value error in fdt_rw.c Rob Herring
[not found] ` <CAL_JsqK68HjwdT5+-kjo3Yr7XokC=6ioa7dkMzeUsve8iEzVxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-03-03 8:33 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD9J8OVvACNd4ppy@yekko.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=ryan.long-lGxtRh3/QYtBDgjK7y7TUQ@public.gmane.org \
--cc=thisisryanlong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).