From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "Marc-André Lureau"
<marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Devicetree Compiler
<devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/2] setup.py: fix out of tree build
Date: Tue, 4 Jan 2022 12:12:55 -0600 [thread overview]
Message-ID: <CAL_Jsq+yNJ9wUR=LNdr7SysEpwXzoT34wh8G3MJ5mW+mAv+PwA@mail.gmail.com> (raw)
In-Reply-To: <20220103073855.1468799-3-marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Mon, Jan 3, 2022 at 1:39 AM <marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>
> From: Marc-André Lureau <marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
$subject is a non-feature IMO. Please see the my recent reply to your
patch from a year ago.
IMO, we should keep meson/Makefile and setup.py builds/tooling
separate. Each has their own ideas about how things work. The path
handling hacks that were in setup.py are just going to cause more
problems when we move to the new Python way with setup.cfg^W
pyproject.toml.
Rob
>
> Fixes: commit 1cc41b1c9 ("pylibfdt: Add packaging metadata")
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> setup.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/setup.py b/setup.py
> index 00444e64337b..029aa6182221 100755
> --- a/setup.py
> +++ b/setup.py
> @@ -17,7 +17,7 @@ import sys
>
> srcdir = os.path.dirname(__file__)
>
> -with open("README", "r") as fh:
> +with open(os.path.join(srcdir, "README"), "r") as fh:
> long_description = fh.read()
>
> def get_top_builddir():
> --
> 2.34.1.8.g35151cf07204
>
prev parent reply other threads:[~2022-01-04 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 7:38 [PATCH 0/2] Some build fixes marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA
[not found] ` <20220103073855.1468799-1-marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-01-03 7:38 ` [PATCH 1/2] Revert "libfdt: Add static lib to meson build" marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA
[not found] ` <20220103073855.1468799-2-marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-01-03 9:59 ` Simon Glass
[not found] ` <CAPnjgZ2+SdumGaCp7TTvJ-WtC4=VdH6mbvAL+q6Hx3oRoCtjEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-01-03 10:04 ` Marc-André Lureau
[not found] ` <CAMxuvazDvsbMekArEngSECHrE0EzzLccZtPVUj44SZ0s-=NwqA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-01-03 10:17 ` Simon Glass
[not found] ` <CAPnjgZ1tK09j8b+kAyZKLjnB9fNY=3yP4e=CeSyPTJmfauLbkg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-01-03 10:22 ` Marc-André Lureau
[not found] ` <CAMxuvayq16QG29M7zyOd_bYVH+=Xyu8D-XTyrxuFSVYF+ipXbw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-01-03 23:47 ` David Gibson
2022-01-03 7:38 ` [PATCH 2/2] setup.py: fix out of tree build marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA
[not found] ` <20220103073855.1468799-3-marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-01-03 23:49 ` David Gibson
2022-01-04 18:12 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+yNJ9wUR=LNdr7SysEpwXzoT34wh8G3MJ5mW+mAv+PwA@mail.gmail.com' \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marcandre.lureau-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).