From: "Pierre-Clément Tosi" <ptosi@google.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: devicetree-compiler@vger.kernel.org
Subject: [PATCH] libfdt: fdt_path_offset_namelen: Reject empty path
Date: Fri, 6 Oct 2023 13:48:39 +0100 [thread overview]
Message-ID: <20231006124839.z7auhc3mk37gxios@google.com> (raw)
Make empty paths result in FDT_ERR_BADPATH.
Per the specification (v0.4-rc4):
> The convention for specifying a device path is:
> /node-name-1/node-name-2/node-name-N
>
> The path to the root node is /.
>
> A unit address may be omitted if the full path to the
> node is unambiguous.
Signed-off-by: Pierre-Clément Tosi <ptosi@google.com>
---
libfdt/fdt_ro.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libfdt/fdt_ro.c b/libfdt/fdt_ro.c
index c4c520c..46b4ef5 100644
--- a/libfdt/fdt_ro.c
+++ b/libfdt/fdt_ro.c
@@ -255,6 +255,9 @@ int fdt_path_offset_namelen(const void *fdt, const char *path, int namelen)
FDT_RO_PROBE(fdt);
+ if (namelen < 1)
+ return -FDT_ERR_BADPATH;
+
/* see if we have an alias */
if (*path != '/') {
const char *q = memchr(path, '/', end - p);
--
2.42.0.609.gbb76f46606-goog
--
Pierre
next reply other threads:[~2023-10-06 12:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 12:48 Pierre-Clément Tosi [this message]
2023-10-06 13:22 ` [PATCH] libfdt: fdt_path_offset_namelen: Reject empty path Simon Glass
2023-10-07 11:17 ` Pierre-Clément Tosi
2023-10-08 2:32 ` David Gibson
2023-10-06 14:06 ` Rob Herring
2023-10-06 22:42 ` Simon Glass
2023-10-07 11:21 ` Pierre-Clément Tosi
2023-10-08 2:32 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006124839.z7auhc3mk37gxios@google.com \
--to=ptosi@google.com \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).