From: Qun-Wei Lin <qun-wei.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
casper.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
chinwen.chang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
kuan-ying.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
ivan.tseng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
ladon.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
Qun-Wei Lin <qun-wei.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Subject: [PATCH] checks: Update #{size,address}-cells check for 'dma-ranges'
Date: Thu, 12 Jan 2023 20:56:54 +0800 [thread overview]
Message-ID: <20230112125654.13390-1-qun-wei.lin@mediatek.com> (raw)
The "dma-ranges" property value is a sequence of
child-address parent-address child-size
The size of each field is determined by taking the child's
"#address-cells" value, the parent's "#address-cells" value,
and the child's "#size-cells" value.
However, in the following example, it gives a false alarm:
+-----------------------------------+---------------------------------------+
| ranges.dts | dma-ranges.dts |
+-----------------------------------+---------------------------------------+
| /dts-v1/; | /dts-v1/; |
| | |
| /{ | /{ |
| #address-cells = <1>; | #address-cells = <1>; |
| | |
| parent { | parent { |
| #address-cells = <1>; | #address-cells = <1>; |
| #size-cells = <1>; | #size-cells = <1>; |
| ranges = <0x0 0xe000 0x1000>; | dma-ranges = <0x0 0xe000 0x1000>; |
| child { | child { |
| ... | ... |
| }; | }; |
| }; | }; |
| }; | }; |
+-----------------------------------+---------------------------------------+
| no warning | Warning (avoid_unnecessary_addr_size) |
+-----------------------------------+---------------------------------------+
Same as "ranges", it should not be reported in this check.
Signed-off-by: Qun-Wei Lin <qun-wei.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
checks.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/checks.c b/checks.c
index afa8f23..607e0f2 100644
--- a/checks.c
+++ b/checks.c
@@ -1232,7 +1232,7 @@ static void check_avoid_unnecessary_addr_size(struct check *c, struct dt_info *d
if (!node->parent || node->addr_cells < 0 || node->size_cells < 0)
return;
- if (get_property(node, "ranges") || !node->children)
+ if (get_property(node, "ranges") || get_property(node, "dma-ranges") || !node->children)
return;
for_each_child(node, child) {
@@ -1242,7 +1242,7 @@ static void check_avoid_unnecessary_addr_size(struct check *c, struct dt_info *d
}
if (!has_reg)
- FAIL(c, dti, node, "unnecessary #address-cells/#size-cells without \"ranges\" or child \"reg\" property");
+ FAIL(c, dti, node, "unnecessary #address-cells/#size-cells without \"ranges\", \"dma-ranges\" or child \"reg\" property");
}
WARNING(avoid_unnecessary_addr_size, check_avoid_unnecessary_addr_size, NULL, &avoid_default_addr_size);
--
2.18.0
next reply other threads:[~2023-01-12 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 12:56 Qun-Wei Lin [this message]
[not found] ` <20230112125654.13390-1-qun-wei.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2023-01-12 19:47 ` [PATCH] checks: Update #{size,address}-cells check for 'dma-ranges' Rob Herring
[not found] ` <CAL_JsqKkE_Aytd_7WOV3iM+pipjnwDWR7yt=L+xE8+cyjL8b9w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-02-02 6:49 ` David Gibson
2023-02-02 6:48 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112125654.13390-1-qun-wei.lin@mediatek.com \
--to=qun-wei.lin-nus5lvnupcjwk0htik3j/w@public.gmane.org \
--cc=casper.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=chinwen.chang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ivan.tseng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=kuan-ying.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=ladon.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).