devicetree-compiler.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

From: Qun-Wei Lin <qun-wei.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	casper.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
	chinwen.chang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
	kuan-ying.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
	ivan.tseng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
	ladon.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
	Qun-Wei Lin <qun-wei.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Subject: [PATCH] checks: Suppress warnings on overlay fragments
Date: Wed, 11 Jan 2023 10:34:17 +0800	[thread overview]
Message-ID: <20230111023417.24141-1-qun-wei.lin@mediatek.com> (raw)

The overlay fragment is a speial case where some properties are not
present in the overlay source file, but in the base file.

example:
+-----------------------------+--------------------+
| base.dts                    | overlay.dts        |
+-----------------------------+--------------------+
| /dts-v1/;                   | /dts-v1/;          |
|                             | /plugin/;          |
| /{                          |                    |
|   parent: test {            | &parent {          |
|     #address-cells = <1>;   |   child@0 {        |
|     #size-cells = <0>;      |     reg = <0x0>;   |
|   };                        |   };               |
| };                          | };                 |
+-----------------------------+--------------------+

It will cause the following false alarms when compiling the overlay dts.

1. /fragment@0/__overlay__: Character '_' not recommended in node name
2. /fragment@0/__overlay__: Relying on default #address-cells value
3. /fragment@0/__overlay__: Relying on default #size-cells value
4. /fragment@0/__overlay__:reg: property has invalid length (4 bytes)
   (#address-cells == 2, #size-cells == 1)

This workaround will fix them by skip checking for node named __overlay__.

Signed-off-by: Qun-Wei Lin <qun-wei.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
 checks.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/checks.c b/checks.c
index 9f31d26..afa8f23 100644
--- a/checks.c
+++ b/checks.c
@@ -325,6 +325,9 @@ static void check_node_name_chars_strict(struct check *c, struct dt_info *dti,
 {
 	int n = strspn(node->name, c->data);
 
+	if (streq(node->name, "__overlay__"))
+		return;
+
 	if (n < node->basenamelen)
 		FAIL(c, dti, node, "Character '%c' not recommended in node name",
 		     node->name[n]);
@@ -767,6 +770,9 @@ static void check_reg_format(struct check *c, struct dt_info *dti,
 		return;
 	}
 
+	if (streq(node->parent->name, "__overlay__"))
+		return;
+
 	if (prop->val.len == 0)
 		FAIL_PROP(c, dti, node, prop, "property is empty");
 
@@ -1197,6 +1203,10 @@ static void check_avoid_default_addr_size(struct check *c, struct dt_info *dti,
 	if (!node->parent)
 		return; /* Ignore root node */
 
+
+	if (streq(node->parent->name, "__overlay__"))
+		return;
+
 	reg = get_property(node, "reg");
 	ranges = get_property(node, "ranges");
 
-- 
2.18.0

next             reply	other threads:[~2023-01-11  2:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11  2:34 Qun-Wei Lin [this message]
     [not found] ` <20230111023417.24141-1-qun-wei.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2023-02-01 11:23   ` [PATCH] checks: Suppress warnings on overlay fragments Qun-wei Lin (林群崴)
2023-02-01 20:29   ` Rob Herring

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:9f31d26 dfblob:afa8f23
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230111023417.24141-1-qun-wei.lin@mediatek.com \
    --to=qun-wei.lin-nus5lvnupcjwk0htik3j/w@public.gmane.org \
    --cc=casper.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=chinwen.chang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
    --cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ivan.tseng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=kuan-ying.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=ladon.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).