From: Andre Przywara <andre.przywara-5wv7dgnIgG8@public.gmane.org>
To: David Gibson
<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v3 0/3] dtc: checks: Validate interrupt-map properties
Date: Tue, 2 Jun 2020 12:04:16 +0100 [thread overview]
Message-ID: <20200602110419.22488-1-andre.przywara@arm.com> (raw)
v3 just adds prerequisites for the existing interrupts_property test,
to avoid double checks.
Changelog below.
===============
The interrupt-map properties can be quite tricky, as they are already
hard to read in their source form, and depend on at least two nodes.
The first patch adds a separate test for interrupt providers, to avoid
redundant warnings for missing properties later.
Patch 2/3 is the actual check routine, to verify some features
of the map. In particular it should be able to spot missing fields or
fields using the wrong number of cells. Most of the fields cannot easily
be verified, but at the least the phandle to the interrupt controller and
the total number of cells in the property should be valid.
It actually find problems in the Linux kernel tree's .dts files.
The third patch is more a proof of concept, not sure it should be merged
as is, since it deviates from the current output scheme: It adds more
output in case a map is considered broken, so the issue can be found
much easier.
I would be happy with it living on the list for now.
Please let me know what you think.
Cheers,
Andre
Changelog v2 .. v3:
- add new prerequisites for interrupts_property test
Changelog v1 .. v2:
- change silent returns to asserts if no #interrupt-cells is found
- add prerequisites to interrupt_map test
Changelog RFC .. v1:
- add extra test for #interrupt-cells and #address-cells
- report expected and actual interrupt-map property length
- drop (now) redundant warnings
- explicitly check for overlay DT
- consider nested interrupt-map properties
Andre Przywara (3):
checks: Add interrupt provider test
checks: Validate interrupt-map properties
checks: interrupt-map: Dump entries on error
checks.c | 194 +++++++++++++++++++++++++++++++++++--
tests/bad-interrupt-controller.dts | 7 ++
tests/bad-interrupt-map.dts | 21 ++++
tests/run_tests.sh | 2 +
4 files changed, 218 insertions(+), 6 deletions(-)
create mode 100644 tests/bad-interrupt-controller.dts
create mode 100644 tests/bad-interrupt-map.dts
--
2.14.1
next reply other threads:[~2020-06-02 11:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 11:04 Andre Przywara [this message]
[not found] ` <20200602110419.22488-1-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2020-06-02 11:04 ` [PATCH v3 1/3] checks: Add interrupt provider test Andre Przywara
[not found] ` <20200602110419.22488-2-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2020-06-08 19:48 ` Rob Herring
2020-06-10 5:10 ` David Gibson
[not found] ` <20200610051057.GM494336-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2020-06-11 20:04 ` Rob Herring
2020-06-02 11:04 ` [PATCH v3 2/3] checks: Validate interrupt-map properties Andre Przywara
[not found] ` <20200602110419.22488-3-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2020-06-08 20:12 ` Rob Herring
2020-06-02 11:04 ` [RFC PATCH v3 3/3] checks: interrupt-map: Dump entries on error Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602110419.22488-1-andre.przywara@arm.com \
--to=andre.przywara-5wv7dgnigg8@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).