From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
Cc: Joel Stanley <joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] checks: Remove warning for I2C_OWN_SLAVE_ADDRESS
Date: Fri, 22 May 2020 17:48:15 +1000 [thread overview]
Message-ID: <20200522074815.GA395888@umbus.fritz.box> (raw)
In-Reply-To: <20200521165009.5668082b-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2106 bytes --]
On Thu, May 21, 2020 at 04:50:09PM +1000, Stephen Rothwell wrote:
> Hi David,
>
> On Thu, 21 May 2020 15:09:14 +1000 David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6ryscVyMRj84@public.gmane.org.au> wrote:
> >
> > On Wed, May 20, 2020 at 05:21:34PM +0930, Joel Stanley wrote:
> > > dtc does a sanity check on reg properties that they are within the 10
> > > bit address range for i2c slave addresses. In the case of multi-master
> > > buses the binding may describe an address that the bus will listen on as
> > > a device. Do not warn when this flag is set.
> > >
> > > This fixes the following build warnings reported by Stephen:
> > >
> > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:126.11-130.4:
> > > Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:
> > > I2C bus unit address format error, expected "40000010"
> > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:128.3-30:
> > > Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:reg:
> > > I2C address must be less than 10-bits, got "0x40000010"
> > >
> > > Reported-by: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
> > > Signed-off-by: Joel Stanley <joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
> >
> > Any document you can give a pointer two explaining the special meaning
> > of this bit?
> include/dt-bindings/i2c/i2c.h
> Is Documentation/devicetree/bindings/i2c/i2c.txt in the kernel tree
> sufficient?
Good enough.
> I2C_OWN_SLAVE_ADDRESS has been in there since the file was
> introduced in August 2015. The actual value has been in
> include/dt-bindings/i2c/i2c.h since the same time.
Looking at that, though, it seems like we should also ignore the
I2C_TEN_BIT_ADDRESS flag. Or better yet, not ignore it but validate
the base addres is under 7 bits unless its set.
Can we refine that a bit, and fix the spelling errors?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-05-22 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 7:51 [PATCH] checks: Remove warning for I2C_OWN_SLAVE_ADDRESS Joel Stanley
[not found] ` <20200520075134.1048589-1-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
2020-05-21 5:09 ` David Gibson
[not found] ` <20200521050914.GE63349-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2020-05-21 6:50 ` Stephen Rothwell
[not found] ` <20200521165009.5668082b-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2020-05-22 7:48 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522074815.GA395888@umbus.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).