From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Jan Beulich <jbeulich-IBi9RG/b67k@public.gmane.org>
Cc: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] libfdt: fix undefined behaviour in fdt_splice_()
Date: Fri, 13 Mar 2020 11:24:12 +1100 [thread overview]
Message-ID: <20200313002412.GE711223@umbus.fritz.box> (raw)
In-Reply-To: <4eaa4349-edbf-eb53-637d-b62a20befddd-IBi9RG/b67k@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]
On Thu, Mar 12, 2020 at 09:19:06AM +0100, Jan Beulich wrote:
> David,
>
> On 11.03.2020 05:59, David Gibson wrote:
> > On Thu, Mar 05, 2020 at 03:04:45PM +0100, Jan Beulich wrote:
> >> libfdt: fix undefined behaviour in fdt_splice_()
> >>
> >> Along the lines of commit d0b3ab0a0f46 ("libfdt: Fix undefined behaviour
> >> in fdt_offset_ptr()"), fdt_splice_() similarly may not use pointer
> >> arithmetic to do overflow checks. (The left side of the checks added by
> >> d4c7c25c9ed1 ["libfdt: check for potential overrun in _fdt_splice()"]
> >> doesn't really lend itself to similar replacement though.)
> >>
> >> Signed-off-by: Jan Beulich <jbeulich-IBi9RG/b67k@public.gmane.org>
> >
> > Applied, thanks.
>
> would you mind pointing me at the tree that you applied this to?
> >From looking around I got the impression that
>
> https://git.kernel.org/pub/scm/utils/dtc/dtc.git
>
> would be the master tree, but I can't see any commit there newer
> than from 8 days ago. The reason I'm asking is because I found
> the issue originally in the Xen tree, which had imported libfdt
> from the DTC project, and in order to submit the (backported)
> fix there I'd like to be able to name the master tree's commit
> hash.
Oh, sorry, I just forgot to push it out from my local tree. It should
be there now.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-03-13 0:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 14:04 [PATCH] libfdt: fix undefined behaviour in fdt_splice_() Jan Beulich
[not found] ` <f2d09e81-7cb8-c5cc-9699-1ac05b0626ff-IBi9RG/b67k@public.gmane.org>
2020-03-11 4:59 ` David Gibson
[not found] ` <20200311045914.GY660117-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2020-03-12 8:19 ` Jan Beulich
[not found] ` <4eaa4349-edbf-eb53-637d-b62a20befddd-IBi9RG/b67k@public.gmane.org>
2020-03-13 0:24 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313002412.GE711223@umbus.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jbeulich-IBi9RG/b67k@public.gmane.org \
--cc=jdl-CYoMK+44s/E@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).