From: Richard Sailer <richard_siegfried@systemli.org>
To: dccp@vger.kernel.org
Subject: Re: [PATCH net-next v5] net: dccp: Add SIOCOUTQ IOCTL support (send buffer fill)
Date: Thu, 23 Jul 2020 10:28:08 +0000 [thread overview]
Message-ID: <be70bbe3-4a8e-8a17-e808-1e1e668e3318@systemli.org> (raw)
In-Reply-To: <20200720160614.117090-1-richard_siegfried@systemli.org>
[-- Attachment #1.1: Type: text/plain, Size: 787 bytes --]
>
> Applied, but I wonder if you'll also need something like tcp's SIOCOUTQNSD?
>
A good question. SIOCOUTQNSD is not mentioned in man 7 tcp and I didn't
know and consider it. Now that I looked it up (bytes of unsent packets
in send buffer) maybe this patch's ioctl should be renamed SIOCOUTQNSD,
since it returns the byte count of unsent packets.
I'm undecided here, this is also the only of these ioctl's that makes
sense for DCCP since DCCP does not keep sent but un-acked packets so
SIOCOUTQ does not exist for DCCP. Or SIOCOUTQ and SIOCOUTQNSD are the
same for DCCP, that's a viewpoint question. And it's anyhow correctly
documented in dccp.rst, it's about unsent packets.
So I'm undecided here, should I resend my patch renamed to SIOCOUTQNSD?
-- Richard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-07-23 10:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 16:06 [PATCH net-next v5] net: dccp: Add SIOCOUTQ IOCTL support (send buffer fill) Richard Sailer
2020-07-23 0:01 ` David Miller
2020-07-23 10:28 ` Richard Sailer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be70bbe3-4a8e-8a17-e808-1e1e668e3318@systemli.org \
--to=richard_siegfried@systemli.org \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).