From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tom Schwindl <schwindl@posteo.de>
Cc: dash@vger.kernel.org
Subject: Re: STATIC vs static
Date: Mon, 20 Feb 2023 17:04:30 +0800 [thread overview]
Message-ID: <Y/M3nmu6MdFLaCtm@gondor.apana.org.au> (raw)
In-Reply-To: <CQKVLXJRDK3X.124XXVEY9RH6K@morphine>
Tom Schwindl <schwindl@posteo.de> wrote:
> Hi all,
>
> as I was skimming through the codebase, I noticed that sometimes there is a
> macro, STATIC, used to represent the normal static. Is there a reason for that
> or would a s/STATIC/static/g be welcome? Now that we are revising the prototypes
> anyway I think it's the right time to bring this up.
There is no reason why STATIC should exist in dash. But if we're
going to clean it up we should make the whole function prototype and
definition consistent and not just the one word.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2023-02-20 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 13:35 STATIC vs static Tom Schwindl
2023-02-20 9:04 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/M3nmu6MdFLaCtm@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dash@vger.kernel.org \
--cc=schwindl@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).