From: Denys Vlasenko <vda.linux@googlemail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
DASH shell mailing list <dash@vger.kernel.org>
Subject: SEGV parsing of ${#1\x82} and ${#1\x84}
Date: Sat, 19 Jun 2021 14:44:46 +0200 [thread overview]
Message-ID: <CAK1hOcNX1K_o0E7eFDAD2FYE8WCTpj1hUfzyvQstEQ5S=6onHg@mail.gmail.com> (raw)
Hi,
CTLVAR and CTLBACKQ are not properly handled if encountered
inside {$#...}. Testcase:
dash -c "`printf 'echo ${#1\x82}'`" 00 111 222
It should execute "echo ${#1 <byte 0x82> }" and thus print "3"
(the length of $1, which is "111").
Instead, it segfaults.
(Ideally, it should fail since "1 <byte 0x82>" is not a valid
variable name, but currently dash accepts e.g. "${#1abc}"
as if it is "${#1}bc". A separate, less serious bug...).
next reply other threads:[~2021-06-19 12:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 12:44 Denys Vlasenko [this message]
2021-06-21 9:57 ` [PATCH] parser: Fix VSLENGTH parsing with trailing garbage Herbert Xu
2021-06-21 14:21 ` Denys Vlasenko
2021-06-22 0:19 ` Herbert Xu
2021-06-22 8:34 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK1hOcNX1K_o0E7eFDAD2FYE8WCTpj1hUfzyvQstEQ5S=6onHg@mail.gmail.com' \
--to=vda.linux@googlemail.com \
--cc=dash@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).