From: Dimitar Yurukov <mscalindt@gmail.com>
To: dash@vger.kernel.org
Cc: Dimitar Yurukov <mscalindt@gmail.com>
Subject: [PATCH] expand: Recognize '^' as a negation character in BE
Date: Fri, 16 Jul 2021 12:42:27 +0300 [thread overview]
Message-ID: <20210716094227.15177-1-mscalindt@gmail.com> (raw)
While parsing bracket expression ('[...]'), DASH recognizes only '!' as
a special character for negation/inversion, but POSIX specifies '^'.
The POSIX specification (2018 edition) states:
^ The <circumflex> shall signify a non-matching list expression when
it occurs first in a list, immediately following a
<left-square-bracket> (see RE Bracket Expression).
DASH:
$ i='123 asd' && printf "%s\n" "${i##*[!a-z]}"
asd
$ i='123 asd' && printf "%s\n" "${i##*[^a-z]}"
<empty expansion>
BASH (with --posix):
$ i='123 asd' && printf "%s\n" "${i##*[!a-z]}"
asd
$ i='123 asd' && printf "%s\n" "${i##*[^a-z]}"
asd
Make <circumflex> ('^') a special character used to specify
negation/inversion in bracket expressions:
$ i='123 asd' && printf "%s\n" "${i##*[^a-z]}"
asd
Signed-off-by: Dimitar Yurukov <mscalindt@gmail.com>
---
src/expand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/expand.c b/src/expand.c
index 1730670..06392ff 100644
--- a/src/expand.c
+++ b/src/expand.c
@@ -1565,7 +1565,7 @@ pmatch(const char *pattern, const char *string)
startp = p;
invert = 0;
- if (*p == '!') {
+ if (*p == '!' || *p == '^') {
invert++;
p++;
}
--
2.32.0
next reply other threads:[~2021-07-16 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 9:42 Dimitar Yurukov [this message]
2021-07-16 10:00 ` [PATCH] expand: Recognize '^' as a negation character in BE Harald van Dijk
2021-07-16 12:46 ` Dimitar Yurukov
2021-07-16 12:50 ` [PATCH v2] " Dimitar Yurukov
2021-07-19 5:13 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716094227.15177-1-mscalindt@gmail.com \
--to=mscalindt@gmail.com \
--cc=dash@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).