From: Herbert Xu <herbert@gondor.apana.org.au>
To: Michael Biebl <biebl@debian.org>
Cc: Andrej Shadura <andrew.shadura@collabora.co.uk>,
dash@vger.kernel.org, 974705@bugs.debian.org
Subject: Re: Changes to job handling cause hangs in wait
Date: Mon, 7 Dec 2020 14:55:06 +1100 [thread overview]
Message-ID: <20201207035505.GA10592@gondor.apana.org.au> (raw)
In-Reply-To: <8f71b2dc-bb40-ec95-51a9-2b60e730bc84@debian.org>
On Thu, Dec 03, 2020 at 01:27:51PM +0100, Michael Biebl wrote:
>
> Hm, so I applied this change and switched backed to dash, but now I get
>
> autopkgtest systemd --test-name=timedated -s -- lxc -s autopkgtest-sid
> ...
> disable NTP
> enable NTP
> Terminated
> autopkgtest [13:21:42]: test timedated: -----------------------]
> autopkgtest [13:21:42]: test timedated: - - - - - - - - - - results - - - -
> - - - - - -
> timedated FAIL non-zero exit status 143
>
>
> Running with sh -x
> ...
> + kill 825
> + wait 825
> Terminated
>
>
> Herbert, any idea what going wrong there?
> (systemd 247.1-2 and dash 0.5.11+git20200708+dd9ef66-2)
Sorry, my bad. wait(1) with no arguments ignores the error status
of the child and always return zero. wait(1) specifically on a
child obviously returns the error status of that child. Since the
child was killed, we need to ignore that, so this works for me:
wait $MONPID 2> /dev/null || :
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-12-07 3:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 10:29 Changes to job handling cause hangs in wait Andrej Shadura
2020-11-17 3:33 ` Herbert Xu
2020-12-01 5:38 ` Herbert Xu
2020-12-01 5:42 ` Herbert Xu
2020-12-01 6:06 ` Herbert Xu
2020-12-01 6:56 ` Herbert Xu
2020-12-01 23:21 ` Michael Biebl
2020-12-01 23:26 ` Herbert Xu
2020-12-02 5:31 ` [PATCH] jobs: Only block in waitcmd on first run Herbert Xu
2020-12-03 12:27 ` Changes to job handling cause hangs in wait Michael Biebl
2020-12-07 3:55 ` Herbert Xu [this message]
2020-12-03 12:49 ` Michael Biebl
2020-12-01 10:14 ` Harald van Dijk
2020-12-01 10:34 ` Herbert Xu
2020-12-01 10:50 ` Harald van Dijk
2020-12-01 10:53 ` Herbert Xu
2020-12-01 10:55 ` Harald van Dijk
2020-12-01 10:56 ` Herbert Xu
2020-12-01 10:59 ` Harald van Dijk
2020-12-01 11:01 ` Herbert Xu
2020-12-01 13:04 ` Michael Biebl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207035505.GA10592@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=974705@bugs.debian.org \
--cc=andrew.shadura@collabora.co.uk \
--cc=biebl@debian.org \
--cc=dash@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).