From: Herbert Xu <herbert@gondor.apana.org.au>
To: "René Scharfe" <l.s.r@web.de>
Cc: dash@vger.kernel.org
Subject: [PATCH] shell: Disable glob again as it strips traing slashes
Date: Mon, 16 Nov 2020 13:52:22 +1100 [thread overview]
Message-ID: <20201116025222.GA28742@gondor.apana.org.au> (raw)
In-Reply-To: <20201116024748.GA26881@gondor.apana.org.au>
On Mon, Nov 16, 2020 at 01:47:48PM +1100, Herbert Xu wrote:
> René Scharfe <l.s.r@web.de> wrote:
> >
> > on Debian testing dash eats trailing slashes of parameters that happen
> > to be regular files when expanding "$@". Example:
> >
> > $ rm -f foo bar
> > $ touch foo
> > $ dash -c 'echo "$0" "$@"' baz foo/ bar/ ./
> > baz foo bar/ ./
>
> In fact you just have to do
>
> dash -c 'echo bar\/'
>
> This is a bug in glob(3). It's stripping the slash.
>
> I guess we'll just have to disable glob again.
This patch disables glob(3) by default.
Reported-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/configure.ac b/configure.ac
index ab3c02e..e9ae792 100644
--- a/configure.ac
+++ b/configure.ac
@@ -39,8 +39,7 @@ fi
AC_ARG_ENABLE(fnmatch, AS_HELP_STRING(--disable-fnmatch, \
[Do not use fnmatch(3) from libc]))
-AC_ARG_ENABLE(glob, AS_HELP_STRING(--disable-glob, \
- [Do not use glob(3) from libc]))
+AC_ARG_ENABLE(glob, AS_HELP_STRING(--enable-glob, [Use glob(3) from libc]))
dnl Checks for libraries.
@@ -128,7 +127,7 @@ if test "$enable_fnmatch" != no; then
AC_CHECK_FUNCS(fnmatch, use_fnmatch=yes)
fi
-if test "$use_fnmatch" = yes && test "$enable_glob" != no; then
+if test "$use_fnmatch" = yes && test "$enable_glob" = yes; then
AC_CHECK_FUNCS(glob)
fi
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-11-16 2:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 13:33 [PATCH] shell: Enable fnmatch/glob by default René Scharfe
2020-11-16 2:47 ` Herbert Xu
2020-11-16 2:52 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116025222.GA28742@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dash@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).