From: Herbert Xu <herbert@gondor.apana.org.au>
To: Matt Whitlock <dash@mattwhitlock.name>
Cc: dash@vger.kernel.org
Subject: Re: Bug when parsing redirection syntax error
Date: Thu, 4 Jun 2020 13:56:08 +1000 [thread overview]
Message-ID: <20200604035608.GA2485@gondor.apana.org.au> (raw)
In-Reply-To: <1851e5f2-80f5-4bd6-9993-e23a0980bd1e@mattwhitlock.name>
Matt Whitlock <dash@mattwhitlock.name> wrote:
> $ cat <<<EOF
> dash: 4: Syntax error: redirection unexpected
> $ true
> dash: 4: Etrue: not found
>
> This is with Dash 0.5.11.
>
> It looks like the first character after the unexpected redirection operator
> mistakenly gets retained in a buffer somewhere and interferes with the next
> command to be read.
This is because dash needs to clear the unget buffer on reset.
Reported-by: Matt Whitlock <dash@mattwhitlock.name>
Fixes: 17db43b58415 ("input: Allow two consecutive calls to pungetc")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/src/input.c b/src/input.c
index 4987732..d7c101b 100644
--- a/src/input.c
+++ b/src/input.c
@@ -87,6 +87,7 @@ INIT {
RESET {
/* clear input buffer */
basepf.lleft = basepf.nleft = 0;
+ basepf.unget = 0;
popallfiles();
}
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-06-04 3:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 18:55 Bug when parsing redirection syntax error Matt Whitlock
2020-06-04 3:56 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604035608.GA2485@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dash@mattwhitlock.name \
--cc=dash@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).