From: Herbert Xu <herbert@gondor.apana.org.au>
To: Michael Greenberg <michael.greenberg@pomona.edu>
Cc: "dash@vger.kernel.org" <dash@vger.kernel.org>
Subject: Re: [v3 PATCH] mktokens relative TMPDIR
Date: Fri, 15 May 2020 16:30:23 +1000 [thread overview]
Message-ID: <20200515063023.GB28688@gondor.apana.org.au> (raw)
In-Reply-To: <m27dxxr7wq.fsf@pomona.edu>
On Wed, Apr 29, 2020 at 08:04:21PM -0700, Michael Greenberg wrote:
> The mktokens script fails when /tmp isn't writable (e.g., when building
> in a sandbox with a different TMPDIR). Replace absolute references to
> /tmp to relative references to TMPDIR. If TMPDIR is unset or null,
> default to /tmp.
>
> The mkbuiltins script was already hardened to work relative to TMPDIR,
> also defaulting to /tmp.
>
> v2 ensures that TMPDIR is quoted.
> v3 adds an extra quotation that prevents extra pathname expansions.
>
> Signed-off-by: Michael Greenberg <michael.greenberg@pomona.edu>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-05-15 6:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 3:50 [PATCH] mktokens relative TMPDIR Michael Greenberg
2020-04-29 5:59 ` Herbert Xu
2020-04-29 17:51 ` [v2 PATCH] " Michael Greenberg
2020-04-30 2:57 ` Herbert Xu
2020-04-30 3:04 ` [v3 " Michael Greenberg
2020-05-15 6:30 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515063023.GB28688@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dash@vger.kernel.org \
--cc=michael.greenberg@pomona.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).