From: cuiyangpei <cuiyangpei@gmail.com>
To: SeongJae Park <sj@kernel.org>
Cc: akpm@linux-foundation.org, damon@lists.linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
xiongping1@xiaomi.com
Subject: Re: [PATCH 1/2] mm/damon/sysfs: Implement recording feature
Date: Tue, 6 Feb 2024 11:26:59 +0800 [thread overview]
Message-ID: <20240206032659.GA6910@cuiyangpei> (raw)
In-Reply-To: <20240206025659.203155-1-sj@kernel.org>
On Mon, Feb 05, 2024 at 06:56:59PM -0800, SeongJae Park wrote:
> Hi Cuiyangpei,
>
> On Mon, 29 Jan 2024 20:13:16 +0800 cuiyangpei <cuiyangpei@gmail.com> wrote:
>
> > On Sun, Jan 28, 2024 at 08:28:04AM -0800, SeongJae Park wrote:
> > > On Sun, 28 Jan 2024 17:13:00 +0800 cuiyangpei <cuiyangpei@gmail.com> wrote:
> > >
> > > > On Fri, Jan 26, 2024 at 12:04:54AM -0800, SeongJae Park wrote:
> > > [...]
> > > > > So, 'update_schemes_tried_regions' command is firstly handled by
> > > > > 'damon_sysfs_cmd_request_callback()', which is registered as
> > > > > after_wmarks_check() and after_aggregation() callback. Hence
> > > > > 'update_schemes_tried_regions' command is still effectively working in
> > > > > aggregation interval granularity. I think this is what you found, right?
> > > > >
> > > > Yes.
> > > > > If I'm not wrongly understanding your point, I think the concern is valid. I
> > > > > think we should make it works in sampling interval granularity. I will try to
> > > > > make so. Would that work for your use case?
> > > > >
> > > > It's much better than working in aggregation interval.
> > >
> > > Thank you for confirming. I will start working on this.
> > >
> >
> > Great, looking forward to seeing the progress.
>
> Just sent a patch[1] for this.
>
> I also updated DAMON user-space tool, damo, to use this improvement[2]. I hope
> that to help others who using DAMON with their own tool to easily understand
> how they can get the improvement from this patch.
>
> Also, please feel free to ask any questions and/or help.
>
> [1] https://lore.kernel.org/r/20240206025158.203097-1-sj@kernel.org
> [2] https://github.com/awslabs/damo/commit/75af3a1c0b3e79cd3207f0f8df5b5ac39f887450
>
>
> Thanks,
> SJ
>
> [...]
Hi SeongJae,
Thank you for sending the patch. I will verify this feature on the phone and reach out
if I have any questions or require assistance.
Thanks.
prev parent reply other threads:[~2024-02-06 3:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 7:34 [PATCH 1/2] mm/damon/sysfs: Implement recording feature cuiyangpei
2023-11-28 7:34 ` [PATCH 2/2] mm/damon/core: add sysfs nodes to set last_nr_accesses weight cuiyangpei
2023-11-28 16:11 ` [PATCH 1/2] mm/damon/sysfs: Implement recording feature kernel test robot
2023-11-28 16:21 ` kernel test robot
2023-11-28 18:57 ` SeongJae Park
2023-11-29 13:13 ` cuiyangpei
2023-11-29 17:10 ` SeongJae Park
2023-11-30 9:14 ` cuiyangpei
2023-11-30 19:44 ` SeongJae Park
2023-12-01 12:25 ` cuiyangpei
2023-12-01 17:31 ` SeongJae Park
2023-12-03 5:43 ` cuiyangpei
2023-12-03 19:37 ` SeongJae Park
2024-01-22 5:46 ` cuiyangpei
2024-01-22 17:56 ` SeongJae Park
2024-01-26 6:57 ` cuiyangpei
2024-01-26 8:04 ` SeongJae Park
2024-01-28 9:13 ` cuiyangpei
2024-01-28 16:28 ` SeongJae Park
2024-01-29 12:13 ` cuiyangpei
2024-02-06 2:56 ` SeongJae Park
2024-02-06 3:26 ` cuiyangpei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206032659.GA6910@cuiyangpei \
--to=cuiyangpei@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
--cc=xiongping1@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).