From: SeongJae Park <sj@kernel.org>
To: SeongJae Park <sj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/damon/core: check apply interval in
Date: Mon, 5 Feb 2024 12:11:09 -0800 [thread overview]
Message-ID: <20240205201109.88463-1-sj@kernel.org> (raw)
In-Reply-To: <20240204204946.87265-1-sj@kernel.org>
I mistakenly broke the subject of the patch. I will send the complete one
again.
On Sun, 4 Feb 2024 12:49:46 -0800 SeongJae Park <sj@kernel.org> wrote:
> kdamond_apply_schemes() checks apply intervals of schemes and avoid
> further applying any schemes if no scheme passed its apply interval.
> However, the following schemes applying function,
> damon_do_apply_schemes() iterates all schemes without the apply interval
> check. As a result, the shortest apply interval is applied to all
> schemes. Fix the problem by checking the apply interval in
> damon_do_apply_schemes().
>
> Fixes: 42f994b71404 ("mm/damon/core: implement scheme-specific apply interval")
> Cc: <stable@vger.kernel.org> # 6.7.x
> Signed-off-by: SeongJae Park <sj@kernel.org>
> ---
> mm/damon/core.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index 0c144fb466b8..f444734cc613 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -1064,6 +1064,9 @@ static void damon_do_apply_schemes(struct damon_ctx *c,
> damon_for_each_scheme(s, c) {
> struct damos_quota *quota = &s->quota;
>
> + if (c->passed_sample_intervals != s->next_apply_sis)
> + continue;
> +
> if (!s->wmarks.activated)
> continue;
>
> @@ -1216,10 +1219,6 @@ static void kdamond_apply_schemes(struct damon_ctx *c)
> if (c->passed_sample_intervals != s->next_apply_sis)
> continue;
>
> - s->next_apply_sis +=
> - (s->apply_interval_us ? s->apply_interval_us :
> - c->attrs.aggr_interval) / sample_interval;
> -
> if (!s->wmarks.activated)
> continue;
>
> @@ -1235,6 +1234,14 @@ static void kdamond_apply_schemes(struct damon_ctx *c)
> damon_for_each_region_safe(r, next_r, t)
> damon_do_apply_schemes(c, t, r);
> }
> +
> + damon_for_each_scheme(s, c) {
> + if (c->passed_sample_intervals != s->next_apply_sis)
> + continue;
> + s->next_apply_sis +=
> + (s->apply_interval_us ? s->apply_interval_us :
> + c->attrs.aggr_interval) / sample_interval;
> + }
> }
>
> /*
> --
> 2.39.2
prev parent reply other threads:[~2024-02-05 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 20:49 [PATCH] mm/damon/core: check apply interval in SeongJae Park
2024-02-05 20:11 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205201109.88463-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).