From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>, Jakub Acs <acsjakub@amazon.de>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/5] avoid divide-by-zero due to max_nr_accesses overflow
Date: Fri, 20 Oct 2023 17:23:12 +0000 [thread overview]
Message-ID: <20231020172317.64192-1-sj@kernel.org> (raw)
Changes from v1
(https://lore.kernel.org/damon/20231019194924.100347-1-sj@kernel.org/)
- Add Reported-by: Jakub Acs <acsjakub@amazon.de>
The maximum nr_accesses of given DAMON context can be calculated by
dividing the aggregation interval by the sampling interval. Some logics
in DAMON uses the maximum nr_accesses as a divisor. Hence, the value
shouldn't be zero. Such case is avoided since DAMON avoids setting the
agregation interval as samller than the sampling interval. However,
since nr_accesses is unsigned int while the intervals are unsigned long,
the maximum nr_accesses could be zero while casting.
Avoid the divide-by-zero by implementing a function that handles the
corner case (first patch), and replaces the vulnerable direct max
nr_accesses calculations (remaining patches).
Note that the patches for the replacements are divided for broken
commits, to make backporting on required tres easier. Especially, the
last patch is for a patch that not yet merged into the mainline but in
mm tree.
SeongJae Park (5):
mm/damon: implement a function for max nr_accesses safe calculation
mm/damon/core: avoid divide-by-zero during monitoring results update
mm/damon/ops-common: avoid divide-by-zero during region hotness
calculation
mm/damon/lru_sort: avoid divide-by-zero in hot threshold calculation
mm/damon/core: avoid divide-by-zero from pseudo-moving window length
calculation
include/linux/damon.h | 7 +++++++
mm/damon/core.c | 12 +++---------
mm/damon/lru_sort.c | 4 +---
mm/damon/ops-common.c | 5 ++---
4 files changed, 13 insertions(+), 15 deletions(-)
base-commit: e845524c56a529768a8793e96304db09134eafdf
--
2.34.1
next reply other threads:[~2023-10-20 17:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 17:23 SeongJae Park [this message]
2023-10-20 17:23 ` [PATCH v2 1/5] mm/damon: implement a function for max nr_accesses safe calculation SeongJae Park
2023-10-20 17:23 ` [PATCH v2 2/5] mm/damon/core: avoid divide-by-zero during monitoring results update SeongJae Park
2023-10-20 17:23 ` [PATCH v2 3/5] mm/damon/ops-common: avoid divide-by-zero during region hotness calculation SeongJae Park
2023-10-20 17:23 ` [PATCH v2 4/5] mm/damon/lru_sort: avoid divide-by-zero in hot threshold calculation SeongJae Park
2023-10-20 17:23 ` [PATCH 5/5] mm/damon/core: avoid divide-by-zero from pseudo-moving window length calculation SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020172317.64192-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=acsjakub@amazon.de \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).