From: Dirk Brandewie <dirk.brandewie@gmail.com>
To: Stratos Karafotis <stratosk@semaphore.gr>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: dirk.j.brandewie@intel.com,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: intel_pstate: Remove sample parameter in intel_pstate_calc_busy
Date: Thu, 01 May 2014 09:04:25 -0700 [thread overview]
Message-ID: <53627089.8010908@intel.com> (raw)
In-Reply-To: <535FE72D.2020402@semaphore.gr>
On 04/29/2014 10:53 AM, Stratos Karafotis wrote:
> Since commit d37e2b7644 ("intel_pstate: remove unneeded sample buffers")
> we use only one sample. So, there is no need to pass the sample
> pointer to intel_pstate_calc_busy. Instead, get the pointer from
> cpudata. Also, remove the unused SAMPLE_COUNT macro.
>
> While at it, reformat the first line in this function.
>
> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
Acked-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
> ---
> drivers/cpufreq/intel_pstate.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 95b3958..8192ff1 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -32,8 +32,6 @@
> #include <asm/msr.h>
> #include <asm/cpu_device_id.h>
>
> -#define SAMPLE_COUNT 3
> -
> #define BYT_RATIOS 0x66a
> #define BYT_VIDS 0x66b
> #define BYT_TURBO_RATIOS 0x66c
> @@ -553,14 +551,13 @@ static void intel_pstate_get_cpu_pstates(struct cpudata *cpu)
> intel_pstate_set_pstate(cpu, cpu->pstate.max_pstate);
> }
>
> -static inline void intel_pstate_calc_busy(struct cpudata *cpu,
> - struct sample *sample)
> +static inline void intel_pstate_calc_busy(struct cpudata *cpu)
> {
> + struct sample *sample = &cpu->sample;
> int32_t core_pct;
> int32_t c0_pct;
>
> - core_pct = div_fp(int_tofp((sample->aperf)),
> - int_tofp((sample->mperf)));
> + core_pct = div_fp(int_tofp(sample->aperf), int_tofp(sample->mperf));
> core_pct = mul_fp(core_pct, int_tofp(100));
> FP_ROUNDUP(core_pct);
>
> @@ -595,7 +592,7 @@ static inline void intel_pstate_sample(struct cpudata *cpu)
> cpu->sample.mperf -= cpu->prev_mperf;
> cpu->sample.tsc -= cpu->prev_tsc;
>
> - intel_pstate_calc_busy(cpu, &cpu->sample);
> + intel_pstate_calc_busy(cpu);
>
> cpu->prev_aperf = aperf;
> cpu->prev_mperf = mperf;
>
prev parent reply other threads:[~2014-05-01 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 17:53 [PATCH] cpufreq: intel_pstate: Remove sample parameter in intel_pstate_calc_busy Stratos Karafotis
2014-04-30 4:06 ` Viresh Kumar
2014-05-01 16:04 ` Dirk Brandewie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53627089.8010908@intel.com \
--to=dirk.brandewie@gmail.com \
--cc=cpufreq@vger.kernel.org \
--cc=dirk.j.brandewie@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=stratosk@semaphore.gr \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).