From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@rjwysocki.net, linaro-kernel@lists.linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
"ego@linux.vnet.ibm.com" <ego@linux.vnet.ibm.com>
Subject: Re: [PATCH V5 0/3] cpufreq: Introduce cpufreq_freq_transition_{begin|end}()
Date: Mon, 24 Mar 2014 13:53:12 +0530 [thread overview]
Message-ID: <532FEB70.3030206@linux.vnet.ibm.com> (raw)
In-Reply-To: <cover.1395644073.git.viresh.kumar@linaro.org>
On 03/24/2014 01:35 PM, Viresh Kumar wrote:
> Whenever we change the frequency of a CPU, we call the PRECHANGE and POSTCHANGE
> notifiers. They must be serialized, i.e. PRECHANGE and POSTCHANGE notifiers
> should strictly alternate, thereby preventing two different sets of PRECHANGE or
> POSTCHANGE notifiers from interleaving arbitrarily.
>
> The following examples illustrate why this is important:
[...]
> This patchset introduces a new set of routines cpufreq_freq_transition_begin()
> and cpufreq_freq_transition_end(), which will guarantee that calls to frequency
> transition routines are serialized. Later patches force other drivers to use
> these new routines.
>
All the patches in this version look good to me.
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Regards,
Srivatsa S. Bhat
>
> V4: https://lkml.org/lkml/2014/3/21/23
>
> V4->V5:
> - Replaced false with 0 as the variable was of int type instead of bool.
> - There were some discussions about requirement of a barrier, but it looks like
> overkill for now. So, leaving that unless we have a real problem.
>
> Srivatsa S. Bhat (1):
> cpufreq: Make sure frequency transitions are serialized
>
> Viresh Kumar (2):
> cpufreq: Convert existing drivers to use
> cpufreq_freq_transition_{begin|end}
> cpufreq: Make cpufreq_notify_transition &
> cpufreq_notify_post_transition static
>
> drivers/cpufreq/cpufreq-nforce2.c | 4 +--
> drivers/cpufreq/cpufreq.c | 52 +++++++++++++++++++++++++++++-------
> drivers/cpufreq/exynos5440-cpufreq.c | 4 +--
> drivers/cpufreq/gx-suspmod.c | 4 +--
> drivers/cpufreq/integrator-cpufreq.c | 4 +--
> drivers/cpufreq/longhaul.c | 4 +--
> drivers/cpufreq/pcc-cpufreq.c | 4 +--
> drivers/cpufreq/powernow-k6.c | 4 +--
> drivers/cpufreq/powernow-k7.c | 4 +--
> drivers/cpufreq/powernow-k8.c | 4 +--
> drivers/cpufreq/s3c24xx-cpufreq.c | 4 +--
> drivers/cpufreq/sh-cpufreq.c | 4 +--
> drivers/cpufreq/unicore2-cpufreq.c | 4 +--
> include/linux/cpufreq.h | 12 ++++++---
> 14 files changed, 76 insertions(+), 36 deletions(-)
>
prev parent reply other threads:[~2014-03-24 8:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 8:05 [PATCH V5 0/3] cpufreq: Introduce cpufreq_freq_transition_{begin|end}() Viresh Kumar
2014-03-24 8:05 ` [PATCH V5 1/3] cpufreq: Make sure frequency transitions are serialized Viresh Kumar
2014-03-24 8:05 ` [PATCH V5 2/3] cpufreq: Convert existing drivers to use cpufreq_freq_transition_{begin|end} Viresh Kumar
2014-03-24 8:05 ` [PATCH V5 3/3] cpufreq: Make cpufreq_notify_transition & cpufreq_notify_post_transition static Viresh Kumar
2014-03-24 8:23 ` Srivatsa S. Bhat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532FEB70.3030206@linux.vnet.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=cpufreq@vger.kernel.org \
--cc=ego@linux.vnet.ibm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).