From: Mark Brown <broonie@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Xiaoguang Chen <chenxg@marvell.com>,
Stratos Karafotis <stratosk@semaphore.gr>,
Andreas Schwab <schwab@linux-m68k.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Amit Kucheria <amit.kucheria@linaro.org>,
linux-stable@vger.kernel.org, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Potential cpufreq backports for v3.10 LTS
Date: Tue, 7 Oct 2014 12:48:44 +0100 [thread overview]
Message-ID: <20141007114844.GT4609@sirena.org.uk> (raw)
[-- Attachment #1: Type: text/plain, Size: 2366 bytes --]
Hi,
The power management team at Linaro has had a look at the cpufreq
updates since the v3.10 LTS and identified a few patches that look
like they should be in there. The most recent of these is from v3.12 so
they won't apply to any of the more recent stable kernels.
- 59a6342203a7a cpufreq: Fix governor start/stop race condition
This looks like a straight race condition fix.
- 19c763031acb8 cpufreq: serialize calls to __cpufreq_governor()
The commit message here outlines a scenario where this change fixes a
crash which seems like stable material to me. There is a context
change that needs a fixup but it's fairly trivial:
diff --cc drivers/cpufreq/cpufreq.c
index c34d4423f298,7e6baa58a7f2..000000000000
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@@ -1586,8 -1692,10 +1586,9 @@@ static int __cpufreq_governor(struct cp
policy->cpu, event);
mutex_lock(&cpufreq_governor_lock);
- if ((!policy->governor_enabled && (event == CPUFREQ_GOV_STOP)) ||
- if (policy->governor_busy
- || (policy->governor_enabled && event == CPUFREQ_GOV_START)
- || (!policy->governor_enabled
- && (event == CPUFREQ_GOV_LIMITS || event == CPUFREQ_GOV_STOP))) {
++ if (policy->governor_busy ||
++ (!policy->governor_enabled && (event == CPUFREQ_GOV_STOP)) ||
+ (policy->governor_enabled && (event == CPUFREQ_GOV_START))) {
mutex_unlock(&cpufreq_governor_lock);
return -EBUSY;
}
- a857c0b9e24e3 cpufreq: Fix wrong time unit conversion
As noted in the changelog this is a bugfix for non-tick based
systems like full dynticks ones.
There's also this:
- dfa5bb622555d cpufreq: ondemand: Change the calculation of target frequency
This is a small patch which delivers a useful performance improvement
but it's not a bug fix and it does touch the cpufreq core so it
doesn't seem to really fit. On the other hand I've got user reports
that it fixes problems with some multicluster systems that can scale
cluster frequencies independently (the additional stability in the
frequencies selected avoids poor interaction with scheduler as cpufreq
ramps the frequency while the scheduler moves load away from the
cluster), it's simple and it's quite well isolated so I wanted to
mention it.
Thanks,
Mark
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next reply other threads:[~2014-10-07 11:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 11:48 Mark Brown [this message]
2014-10-07 12:14 ` Potential cpufreq backports for v3.10 LTS Mark Brown
2014-10-07 16:46 ` Greg Kroah-Hartman
2014-10-07 17:08 ` Mark Brown
2014-10-07 20:04 ` Greg Kroah-Hartman
2014-10-07 20:45 ` Mark Brown
2014-10-07 21:58 ` Greg Kroah-Hartman
2014-10-07 22:50 ` Mark Brown
2014-10-07 22:56 ` Greg Kroah-Hartman
2014-10-07 21:36 ` Stratos Karafotis
2014-10-07 23:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007114844.GT4609@sirena.org.uk \
--to=broonie@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=chenxg@marvell.com \
--cc=cpufreq@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-stable@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=schwab@linux-m68k.org \
--cc=stratosk@semaphore.gr \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).