From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Stratos Karafotis <stratosk@semaphore.gr>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
Dirk Brandewie <dirk.j.brandewie@intel.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
"David S. Miller" <davem@davemloft.net>,
Linus Walleij <linus.walleij@linaro.org>,
Simon Horman <horms@verge.net.au>, Sekhar Nori <nsekhar@ti.com>,
Samuel Ortiz <samuel@sortiz.org>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH v5 0/8] Introduce new cpufreq helper macros
Date: Thu, 08 May 2014 00:37:27 +0200 [thread overview]
Message-ID: <1628906.bvqGfBpWxn@vostro.rjw.lan> (raw)
In-Reply-To: <536A3654.20201@semaphore.gr>
On Wednesday, May 07, 2014 04:34:12 PM Stratos Karafotis wrote:
> Hi Rafael,
>
> On 07/05/2014 04:13 μμ, Rafael J. Wysocki wrote:
> > On Wednesday, May 07, 2014 10:53:16 AM Viresh Kumar wrote:
> >> On 6 May 2014 23:25, Stratos Karafotis <stratosk@semaphore.gr> wrote:
> >>> My bad. I'm sorry for this. :(
> >>>
> >>> Rafael,
> >>> A solution could be to make cpufreq_next_valid an inline function in cpufreq.h,
> >>> but as Viresh mentioned this would be very inefficient because of multiple copies.
> >>
> >> That statement was true when we didn't had this problem..
> >>
> >>> So, maybe it's better to revert the 2 patches that don't depend on CONFIG_CPU_FREQ:
> >>>
> >>> 4229e1c61a4a ("sh: clk: Use cpufreq_for_each_valid_entry macro for iteration") and
> >>> 04ae58645afa ("irda: sh_sir: Use cpufreq_for_each_valid_entry macro for iteration").
> >>
> >> This doesn't look right. It can happen to some other drivers as well in future.
> >> So, there are two solutions I can think of:
> >> 1. move cpufreq_next_valid and rename it to __cpufreq_next_valid(). Also make it
> >> inline. Then create two versions of cpufreq_next_valid(), one inlined (only when
> >> CONFIG_CPU_FREQ=n) and other one in cpufreq.c (non- inlined)..
> >>
> >> But probably that would be called ugly by some people :)
> >>
> >> 2. Make cpufreq_next_valid() inline and forget about extra space it takes :)
> >>
> >> @Rafel: Let me know which one you like :)
> >
> > 2.
> >
> >
>
> Do you want me to resend the entire patch set or only patch 1/8?
It's already on a branch that cannot be rebased. Please send me a fix on top of it.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2014-05-07 22:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 20:15 [PATCH v5 0/8] Introduce new cpufreq helper macros Stratos Karafotis
2014-04-29 4:17 ` Viresh Kumar
2014-04-29 16:05 ` Stratos Karafotis
2014-04-29 22:26 ` Rafael J. Wysocki
2014-04-30 15:37 ` Stratos Karafotis
2014-05-06 15:24 ` Geert Uytterhoeven
2014-05-06 17:55 ` Stratos Karafotis
2014-05-07 5:23 ` Viresh Kumar
2014-05-07 13:13 ` Rafael J. Wysocki
2014-05-07 13:34 ` Stratos Karafotis
2014-05-07 13:36 ` Viresh Kumar
2014-05-07 22:37 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1628906.bvqGfBpWxn@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=cpufreq@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dirk.j.brandewie@intel.com \
--cc=egtvedt@samfundet.no \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=jesper.nilsson@axis.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rdunlap@infradead.org \
--cc=samuel@sortiz.org \
--cc=stratosk@semaphore.gr \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).