From: Ed Swarthout <Ed.Swarthout@freescale.com>
To: rjw@rjwysocki.net, viresh.kumar@linaro.org
Cc: scottwood@freescale.com, linux-pm@vger.kernel.org,
cpufreq@vger.kernel.org,
Ed Swarthout <Ed.Swarthout@freescale.com>
Subject: [PATCH] cpufreq: ppc-corenet-cpu-freq: do_div use quotient
Date: Thu, 5 Jun 2014 18:56:17 -0500 [thread overview]
Message-ID: <1402012577-27354-1-git-send-email-Ed.Swarthout@freescale.com> (raw)
In-Reply-To: <1401917713-20792-1-git-send-email-Ed.Swarthout@freescale.com>
6712d2931933ada259b82f06c03a855b19937074 (cpufreq:
ppc-corenet-cpufreq: Fix __udivdi3 modpost error) used the remainder
from do_div instead of the quotient. Fix that and add one to ensure
minimum is met.
Signed-off-by: Ed Swarthout <Ed.Swarthout@freescale.com>
---
Resend to include linux-pm list.
Decided to rename the temporary variable since the value isn't
a latency until after the division and then it is in nsec.
Tested on t4240qds and p4080ds.
https://patchwork.kernel.org/patch/4296811/
http://patchwork.ozlabs.org/patch/356096/
drivers/cpufreq/ppc-corenet-cpufreq.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/cpufreq/ppc-corenet-cpufreq.c b/drivers/cpufreq/ppc-corenet-cpufreq.c
index 0af618a..3607070 100644
--- a/drivers/cpufreq/ppc-corenet-cpufreq.c
+++ b/drivers/cpufreq/ppc-corenet-cpufreq.c
@@ -138,7 +138,7 @@ static int corenet_cpufreq_cpu_init(struct cpufreq_policy *policy)
struct cpufreq_frequency_table *table;
struct cpu_data *data;
unsigned int cpu = policy->cpu;
- u64 transition_latency_hz;
+ u64 u64temp;
np = of_get_cpu_node(cpu, NULL);
if (!np)
@@ -206,9 +206,10 @@ static int corenet_cpufreq_cpu_init(struct cpufreq_policy *policy)
for_each_cpu(i, per_cpu(cpu_mask, cpu))
per_cpu(cpu_data, i) = data;
- transition_latency_hz = 12ULL * NSEC_PER_SEC;
- policy->cpuinfo.transition_latency =
- do_div(transition_latency_hz, fsl_get_sys_freq());
+ /* Minimum transition latency is 12 platform clocks */
+ u64temp = 12ULL * NSEC_PER_SEC;
+ do_div(u64temp, fsl_get_sys_freq());
+ policy->cpuinfo.transition_latency = u64temp + 1;
of_node_put(np);
--
1.9.1
prev parent reply other threads:[~2014-06-05 23:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 16:18 [PATCH 3.15-rc3] cpufreq: ppc-corenet-cpufreq: Fix __udivdi3 modpost error Tim Gardner
2014-06-04 21:35 ` [PATCH] cpufreq: ppc-corenet-cpu-freq: do_div use quotient Ed Swarthout
2014-06-05 5:23 ` Viresh Kumar
2014-06-05 21:55 ` Rafael J. Wysocki
2014-06-05 23:56 ` Ed Swarthout [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402012577-27354-1-git-send-email-Ed.Swarthout@freescale.com \
--to=ed.swarthout@freescale.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=scottwood@freescale.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).