From: Ben Hutchings <ben@decadent.org.uk>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>
Subject: Re: Another powernow-k6 bug
Date: Mon, 21 Apr 2014 12:45:51 +0100 [thread overview]
Message-ID: <1398080751.3624.97.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <CAOh2x=ndnFUBphVYGRL+x2jra36VS1T_F=sMpkAgm9xi52Qvvg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On Mon, 2014-04-21 at 11:03 +0530, Viresh Kumar wrote:
> On Thu, Apr 17, 2014 at 12:53 AM, Ben Hutchings <ben@decadent.org.uk> wrote:
> > While looking at your recent powernow-k6 fixes (thanks for those), I
> > noticed that powernow_k6_cpu_exit() doesn't work properly:
> >
> > static int powernow_k6_cpu_exit(struct cpufreq_policy *policy)
> > {
> > unsigned int i;
> > for (i = 0; i < 8; i++) {
> > if (i == max_multiplier)
> > powernow_k6_set_state(i);
> > }
>
> Yeah, there is a issue there. But why do we need to set freq to
> highest freq on exit()? Probably this code can be simply removed?
[...]
Because that is how the CPU was running before the driver was loaded.
Ben.
--
Ben Hutchings
Knowledge is power. France is bacon.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
prev parent reply other threads:[~2014-04-21 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 19:23 Another powernow-k6 bug Ben Hutchings
2014-04-21 5:33 ` Viresh Kumar
2014-04-21 11:45 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398080751.3624.97.camel@deadeye.wl.decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=cpufreq@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).