From: Tycho Andersen <tycho-E0fblnxP3wo@public.gmane.org>
To: Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "Tobin C . Harding" <me-xzjC0nNlxno@public.gmane.org>,
Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Akihiro Suda
<suda.akihiro-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>,
"Eric W . Biederman"
<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
Christian Brauner
<christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>,
Tyler Hicks <tyhicks-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Subject: Re: [PATCH v2 1/4] seccomp: add a return code to trap to userspace
Date: Thu, 24 May 2018 09:28:27 -0600 [thread overview]
Message-ID: <20180524152827.GD21405__7441.47368609465$1527175752$gmane$org@cisco> (raw)
In-Reply-To: <20180517154637.GC8586-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Hi Oleg,
On Thu, May 17, 2018 at 05:46:37PM +0200, Oleg Nesterov wrote:
> On 05/17, Tycho Andersen wrote:
> >
> > > From lockdep pov this loop tries to take the same lock twice or more, it shoul
> > > complain.
> >
> > I didn't, but I guess that's because it's not trying to take the same lock
> > twice -- the pointer cur is changing in the loop.
>
> Yes, I see. But this is the same lock for lockdep, it has the same class.
I finally figured this out, I needed CONFIG_PROVE_LOCKING=y too,
anyway, I've added the nesting annotations for v3. Thanks!
Tycho
next prev parent reply other threads:[~2018-05-24 15:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 15:12 [PATCH v2 0/4] seccomp trap to userspace Tycho Andersen
[not found] ` <20180517151218.12850-1-tycho-E0fblnxP3wo@public.gmane.org>
2018-05-17 15:12 ` [PATCH v2 1/4] seccomp: add a return code to " Tycho Andersen
2018-05-17 15:12 ` [PATCH v2 2/4] seccomp: make get_nth_filter available outside of CHECKPOINT_RESTORE Tycho Andersen
2018-05-17 15:12 ` [PATCH v2 3/4] seccomp: add a way to get a listener fd from ptrace Tycho Andersen
2018-05-17 15:12 ` [PATCH v2 4/4] seccomp: add support for passing fds via USER_NOTIF Tycho Andersen
[not found] ` <20180517151218.12850-4-tycho@tycho.ws>
[not found] ` <20180517151218.12850-4-tycho-E0fblnxP3wo@public.gmane.org>
2018-05-17 15:41 ` [PATCH v2 3/4] seccomp: add a way to get a listener fd from ptrace Oleg Nesterov
[not found] ` <20180517154139.GB8586-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-05-17 15:57 ` Tycho Andersen
[not found] ` <20180517155733.GB3831@cisco>
2018-05-17 15:59 ` Tycho Andersen
[not found] ` <20180518140556.GC26297@mailbox.org>
[not found] ` <20180518140556.GC26297-cl+VPiYnx/1AfugRpC6u6w@public.gmane.org>
2018-05-18 15:10 ` Tycho Andersen
[not found] ` <20180517151218.12850-2-tycho@tycho.ws>
[not found] ` <20180517153323.GA8586@redhat.com>
[not found] ` <20180517153323.GA8586-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-05-17 15:39 ` [PATCH v2 1/4] seccomp: add a return code to trap to userspace Tycho Andersen
[not found] ` <20180517153957.GA3831@cisco>
2018-05-17 15:46 ` Oleg Nesterov
[not found] ` <20180517154637.GC8586@redhat.com>
[not found] ` <20180517154637.GC8586-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-05-24 15:28 ` Tycho Andersen [this message]
[not found] ` <20180518140415.GB26297@mailbox.org>
[not found] ` <20180518140415.GB26297-cl+VPiYnx/1AfugRpC6u6w@public.gmane.org>
2018-05-18 15:21 ` Tycho Andersen
[not found] ` <20180517151218.12850-2-tycho-E0fblnxP3wo@public.gmane.org>
2018-05-17 15:33 ` Oleg Nesterov
2018-05-19 0:14 ` kbuild test robot
2018-05-19 5:01 ` kbuild test robot
[not found] ` <201805191041.sVHKG1E9%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-05-21 22:55 ` Tycho Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20180524152827.GD21405__7441.47368609465$1527175752$gmane$org@cisco' \
--to=tycho-e0fblnxp3wo@public.gmane.org \
--cc=christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org \
--cc=me-xzjC0nNlxno@public.gmane.org \
--cc=oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=suda.akihiro-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
--cc=tyhicks-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).