From: Christian Brauner <christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
To: viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Christian Brauner
<christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH 0/4 v5 RESEND] devpts: handle bind-mounts correctly
Date: Tue, 13 Mar 2018 17:55:23 +0100 [thread overview]
Message-ID: <20180313165527.24038-1-christian.brauner__8288.32176416672$1520960066$gmane$org@ubuntu.com> (raw)
Resending to CC grekh.
Hey everyone,
This is the fith iteration of this patch. Per-patch changes are
summarized in the individual patches:
ChangeLog v4->v5:
* added non-functional patch to document devpts_mntget().
Reason for putting this in a separate patch is that it allows you,
Linus and Eric, to simply drop it if judged useless.
* reverse error handling logic to further simplify
* dput() dentry in the non-function patch. This was not really a problem
since the following patch included a fix for it. But better to get it
right in all individual patches.
* I did another rewrite of the problem analysis for
posterity in the patch "Subject: [PATCH 2/3 v3] devpts: resolve devpts
bind-mounts" and in this cover letter.
ChangeLog v3->v4:
* small logical simplifications
* add test that bind-mounts of /dev/pts/ptmx to locations that do not
resolve to a valid slave pty path under the originating devpts mount
fail
ChangeLog v2->v3:
* rewritten commit message to thoroughly analyse the problem for
posterity in the patch "Subject: [PATCH 2/3 v3] devpts: resolve devpts
bind-mounts" and in this cover letter.
* extended selftests to test for correct handling of /dev/pts/ptmx
bind-mounts to /dev/ptmx and non-standard devpts mounts such as
mount -t devpts devpts /mnt
ChangeLog v1->v2:
* see individual patches
ChangeLog v0->v1:
* see individual patches
Christian Brauner (4):
devpts: hoist out check for DEVPTS_SUPER_MAGIC
devpts: resolve devpts bind-mounts
devpts: comment devpts_mntget()
selftests: add devpts selftests
fs/devpts/inode.c | 66 +++--
tools/testing/selftests/Makefile | 1 +
tools/testing/selftests/filesystems/.gitignore | 1 +
tools/testing/selftests/filesystems/Makefile | 2 +-
tools/testing/selftests/filesystems/devpts_pts.c | 313 +++++++++++++++++++++++
5 files changed, 363 insertions(+), 20 deletions(-)
create mode 100644 tools/testing/selftests/filesystems/devpts_pts.c
--
2.15.1
next reply other threads:[~2018-03-13 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 16:55 Christian Brauner [this message]
[not found] <20180313165527.24038-1-christian.brauner@ubuntu.com>
[not found] ` <20180313165527.24038-1-christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2018-03-13 17:32 ` [PATCH 0/4 v5 RESEND] devpts: handle bind-mounts correctly Eric W. Biederman
[not found] ` <87o9jr285m.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2018-03-13 17:40 ` Greg KH
2018-03-13 18:02 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20180313165527.24038-1-christian.brauner__8288.32176416672$1520960066$gmane$org@ubuntu.com' \
--to=christian.brauner-gewih/nmzzlqt0dzr+alfa@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).