From: Daniel Wagner <wagi@monom.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: connman@lists.linux.dev
Subject: Re: libppp-compat.h missing in tar file
Date: Sun, 19 Nov 2023 17:56:18 +0100 [thread overview]
Message-ID: <bacp2536omiilw272akl5xjqaqvodo7aro66tti7gvri36jbb2@brfjeq53sjr4> (raw)
In-Reply-To: <0A339003-F2B6-4BA5-A80D-2211979BEB64@holtmann.org>
Hi Marcel,
On Sun, Nov 19, 2023 at 03:08:29PM +0100, Marcel Holtmann wrote:
> Hi Daniel,
>
> > I noticed that the scripts/libppp-compath.h header file is missing in
> > the tar file. The file is added to EXTRA_DIST variable but this seems
> > not to be right. Where should it be listed?
>
> in general EXTRA_DIST is correct.
Good at least this is correct.
> Why a C header is in scripts/ however is total different question.
This header file came in via
a48864a2e5d2 ("vpn: Adding support for latest pppd 2.5.0 release")
I thought it looked reasonable at this point.
> Can you give some more details here.
Sure, I was updating the rpm package for Tumbleweed. The spec file uses
http://www.kernel.org/pub/linux/network/connman/connman-%{version}.tar.xz
as source and builds all plugins. And this tar file, the header file is missing.
https://build.opensuse.org/package/view_file/openSUSE:Factory/connman/connman.spec
> I didn’t even realize we included a PPP header since pppd was
> something we never preferred and even oFono brings in its own PPP
> implementation.
It's used for l2tp. Does oFono also implement this part?
Thanks,
Daniel
prev parent reply other threads:[~2023-11-19 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 14:35 libppp-compat.h missing in tar file Daniel Wagner
2023-11-19 14:08 ` Marcel Holtmann
2023-11-19 16:56 ` Daniel Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bacp2536omiilw272akl5xjqaqvodo7aro66tti7gvri36jbb2@brfjeq53sjr4 \
--to=wagi@monom.org \
--cc=connman@lists.linux.dev \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).