From: "VAUTRIN Emmanuel (Canal Plus Prestataire)" <Emmanuel.VAUTRIN@cpexterne.org>
To: "connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: RE: [PATCH] service: Fix hidden service with wrong passphrase
Date: Tue, 11 Apr 2023 09:00:50 +0000 [thread overview]
Message-ID: <MRZP264MB1544BE29A8F963CDA91BBE99939A9@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20230411072808.nkxk6iprmgp6jlnz@beryllium.lan>
Hi Daniel,
Thank you spending time integrating my patches.
> This should be handled by the caller of the set function. We are already doing
> this, so please move this part also there.
Do you mean callers of __connman_service_set_passphrase()?
The problem is that there are 4 calls to __connman_service_set_passphrase:
1759 src/network.c <<connman_network_connect_hidden>>
err = __connman_service_set_passphrase(service, passphrase);
5728 src/service.c <<__connman_service_set_string>>
__connman_service_set_passphrase(service, value);
5873 src/service.c <<request_input_cb>>
err = __connman_service_set_passphrase(service, passphrase);
6103 src/service.c <<service_indicate_state>>
__connman_service_set_passphrase(service, pass);
Moreover, in network.c, connman_service is opaque, so it is not possible there.
But maybe I have misunderstood your proposal.
Best Regards,
Emmanuel
prev parent reply other threads:[~2023-04-11 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 17:19 [PATCH] service: Fix hidden service with wrong passphrase VAUTRIN Emmanuel (Canal Plus Prestataire)
2023-03-22 14:14 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2023-04-11 7:28 ` Daniel Wagner
2023-04-11 9:00 ` VAUTRIN Emmanuel (Canal Plus Prestataire) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MRZP264MB1544BE29A8F963CDA91BBE99939A9@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM \
--to=emmanuel.vautrin@cpexterne.org \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).