From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH 0/2] Rename and Document 'switch_default_service'
Date: Tue, 7 Nov 2023 19:52:23 +0100 [thread overview]
Message-ID: <F9379D51-F803-4576-8E66-19F83E4FD77C@holtmann.org> (raw)
In-Reply-To: <37EFB709-B379-4AE2-85F6-0D74564EF4C8@nuovations.com>
Hi Grant,
> This patch patch series renames and documents the ‘switch_default_service' function.
>
> The function ‘switch_default_service' is used in two contexts:
>
> 1. From ‘__connman_service_move', which may be called from either the public D-Bus
> “MoveAfter" or “MoveBefore" method requests or from ‘connman_provider_set_split_routing' in "src/provider.c".
> 2. From ‘service_update_preferred_order' in which the first argument is guaranteed to the default service.
>
> In the D-Bus “MoveAfter" or “MoveBefore" contexts, the ‘switch_default_service' is a misnomer since neither
> service argument, in particular the first, is guaranteed to be the default service. Consequently,
> ‘switch_default_service' is renamed to the more neutral ‘switch_service_order' to reflect its varied usage in the
> above contexts.
both patches have been applied.
Regards
Marcel
prev parent reply other threads:[~2023-11-07 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 0:48 [PATCH 0/2] Rename and Document 'switch_default_service' Grant Erickson
2023-11-03 0:50 ` [PATCH 1/2] service: Rename switch_default_service Grant Erickson
2023-11-03 0:50 ` [PATCH 2/2] Add documentation to 'switch_service_order' Grant Erickson
2023-11-07 18:52 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F9379D51-F803-4576-8E66-19F83E4FD77C@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=gerickson@nuovations.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).