From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH v2] Close three '__connman_wisp_start' failure closure holes.
Date: Tue, 7 Nov 2023 20:10:27 +0100 [thread overview]
Message-ID: <F49C9B00-7F11-41EE-9E32-8BB626ACBFD8@holtmann.org> (raw)
In-Reply-To: <5B470B03-18A6-494A-B6F6-B2CE614A1A7E@nuovations.com>
Hi Grant,
There are currently three failure holes in which a request to
> '__connman_wispr_start' is not properly closed.
>
> 1. If 'g_web_request_get' fails to generate a successful gweb request
> and returns a request identifier of zero (0) in
> 'wispr_portal_request_portal'.
>
> 2. If the service proxy is set to CONNMAN_SERVICE_PROXY_METHOD_UNKNOWN.
> This can happen in 'proxy_callback' if WISPr is started and the
> service proxy method is set latently or is never set at all.
>
> 3. If 'wispr_portal_detect' returns non-zero error status in
> '__connman_wispr_start'.
> ---
> src/wispr.c | 19 +++++++++++++++++--
> 1 file changed, 17 insertions(+), 2 deletions(-)
patch has been applied.
Regards
Marcel
prev parent reply other threads:[~2023-11-07 19:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 21:57 [PATCH] Close three '__connman_wisp_start' failure closure holes Grant Erickson
2023-11-07 15:18 ` Marcel Holtmann
2023-11-07 15:44 ` Grant Erickson
[not found] ` <F2368B90-D59D-4457-9A42-F0543B3AD1E0@nuovations.com>
2023-11-07 18:54 ` Grant Erickson
2023-11-07 18:52 ` [PATCH v2] " Grant Erickson
2023-11-07 19:10 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F49C9B00-7F11-41EE-9E32-8BB626ACBFD8@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=gerickson@nuovations.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).