From: Grant Erickson <gerickson@nuovations.com>
To: connman@lists.linux.dev
Subject: [PATCH 0/6] Fix Segfault from Time Services on Service Removal
Date: Wed, 1 Nov 2023 19:45:48 -0700 [thread overview]
Message-ID: <EA3460D2-744F-4DED-9284-0AC453189BAC@nuovations.com> (raw)
This patch series fixes a heap-use-after-free fault in connman_service_get_nameservers on service removal by:
1. Qualifying the call to ‘__connman_timeserver_sync' in ‘__connman_service_ipconfig_indicate_state' with a ‘is_connected' conditional.
2. Converting the semantics of the ts_service private global in src/timeservice.c from a weak reference (that is, it uses simple assignment) to a strong reference (that is, it uses 'connman_service_{ref,unref}’ plus assignment).
Best,
Grant Erickson
--
Principal
Nuovations
gerickson@nuovations.com
http://www.nuovations.com/
next reply other threads:[~2023-11-02 2:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 2:45 Grant Erickson [this message]
2023-11-02 3:19 ` [PATCH 1/6] Log the service identifer in service_free Grant Erickson
2023-11-02 3:20 ` [PATCH 2/6] timeserver: Expand service debug logging Grant Erickson
2023-11-02 3:20 ` [PATCH 3/6] Qualify request to time-of-day sync with connected check Grant Erickson
2023-11-02 3:20 ` [PATCH 4/6] timeserver: Convert ts_service from a weak to a strong reference Grant Erickson
2023-11-02 3:21 ` [PATCH 5/6] timeservice: Add function documentation for 'ts_reset' Grant Erickson
2023-11-02 3:21 ` [PATCH 6/6] timeservice: Add function documentation for '__connman_timeserver_sync' Grant Erickson
2023-11-07 15:39 ` [PATCH 0/6] Fix Segfault from Time Services on Service Removal Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EA3460D2-744F-4DED-9284-0AC453189BAC@nuovations.com \
--to=gerickson@nuovations.com \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).