From: Marcel Holtmann <marcel@holtmann.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH 0/5] Address Unhandled Gateway Route Lifecycle Events/Transitions
Date: Sat, 23 Dec 2023 13:22:00 +0100 [thread overview]
Message-ID: <E03A875B-7269-453D-860C-362515E875BE@holtmann.org> (raw)
In-Reply-To: <20231220055613.2287074-1-gerickson@nuovations.com>
Hi Grant,
> There were a number of "escapes" or unhandled events and transitions
> that did not adhere to the documented gateway configuration lifecycle
> / state machine.
>
> Failure to handle these was resulting in duplicate default routes, no
> default routes, and incorrect default route priorities for some
> services and their underlying network interfaces.
>
> These "escapes" were handled in three primary ways with this patch series:
>
> 1. Leveraging '__connman_inet_rtnl_recv' in 'iproute_default_modify'.
> 2. Leveraging -ESRCH returned by 'iproute_default_modify'.
> 3. Adding explicit conditional cases for the "escapes" not otherwise
> covered by (1) and (2).
>
> Grant Erickson (5):
> inet: Use '__connman_inet_rtnl_recv' for RTNL default route
> transaction.
> gateway: Handle -ESRCH in 'unset_default_gateway_route_common'.
> gateway: Address unhandled gateway lifecycle events/transitions.
> gateway: Add and leveage 'gateway_config_set_{,in}active'.
> gateway: Expand the @param documentation for
> 'yield_default_gateway{,_for_type}'.
>
> src/gateway.c | 80 +++++++++++++++++++++++++++++++++++++++------------
> src/inet.c | 6 ++++
> 2 files changed, 68 insertions(+), 18 deletions(-)
all 5 patches have been applied.
Regards
Marcel
prev parent reply other threads:[~2023-12-23 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 5:56 [PATCH 0/5] Address Unhandled Gateway Route Lifecycle Events/Transitions Grant Erickson
2023-12-20 5:56 ` [PATCH 1/5] inet: Use '__connman_inet_rtnl_recv' for RTNL default route transaction Grant Erickson
2023-12-20 5:56 ` [PATCH 2/5] gateway: Handle -ESRCH in 'unset_default_gateway_route_common' Grant Erickson
2023-12-20 5:56 ` [PATCH 3/5] gateway: Address unhandled gateway lifecycle events/transitions Grant Erickson
2023-12-20 5:56 ` [PATCH 4/5] gateway: Add and leveage 'gateway_config_set_{,in}active' Grant Erickson
2023-12-20 5:56 ` [PATCH 5/5] gateway: Expand the @param documentation for 'yield_default_gateway{,_for_type}' Grant Erickson
2023-12-23 12:22 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E03A875B-7269-453D-860C-362515E875BE@holtmann.org \
--to=marcel@holtmann.org \
--cc=connman@lists.linux.dev \
--cc=gerickson@nuovations.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).